Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id A0B34200BF4 for ; Fri, 6 Jan 2017 17:07:00 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 9F59F160B37; Fri, 6 Jan 2017 16:07:00 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id E2D6D160B1F for ; Fri, 6 Jan 2017 17:06:59 +0100 (CET) Received: (qmail 28206 invoked by uid 500); 6 Jan 2017 16:06:58 -0000 Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list hdfs-issues@hadoop.apache.org Received: (qmail 28184 invoked by uid 99); 6 Jan 2017 16:06:58 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 06 Jan 2017 16:06:58 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id 9712D2C2A6D for ; Fri, 6 Jan 2017 16:06:58 +0000 (UTC) Date: Fri, 6 Jan 2017 16:06:58 +0000 (UTC) From: "Arpit Agarwal (JIRA)" To: hdfs-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Comment Edited] (HDFS-11182) Update DataNode to use DatasetVolumeChecker MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Fri, 06 Jan 2017 16:07:00 -0000 [ https://issues.apache.org/jira/browse/HDFS-11182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15804872#comment-15804872 ] Arpit Agarwal edited comment on HDFS-11182 at 1/6/17 4:06 PM: -------------------------------------------------------------- Attached a patch for branch-2. [~xyao], can you please take a look at the patch. The main difference from trunk is that in branch-2 DatasetVolumeChecker returns Set whereas in trunk it returns Set. The difference is that due to branch divergence, we cannot get the StorageLocation from an FsVolumeSpi trivially in branch-2. I ran test-patch locally and results are below. Also tested the branch-2 patch by simulating disk failure and verifying that the failure was caught and the volume was removed. | Vote | Subsystem | Runtime | Comment | +1 | @author | 0m 0s | The patch does not contain any @author | | | | tags. | +1 | test4tests | 0m 0s | The patch appears to include 20 new or | | | | modified test files. | +1 | mvninstall | 3m 31s | branch-2 passed | +1 | compile | 0m 26s | branch-2 passed | +1 | checkstyle | 0m 29s | branch-2 passed | +1 | mvnsite | 0m 31s | branch-2 passed | +1 | mvneclipse | 0m 11s | branch-2 passed | +1 | findbugs | 0m 59s | branch-2 passed | +1 | javadoc | 0m 38s | branch-2 passed | +1 | mvninstall | 0m 26s | the patch passed | +1 | compile | 0m 23s | the patch passed | +1 | javac | 0m 23s | the patch passed | -1 | checkstyle | 0m 26s | hadoop-hdfs-project/hadoop-hdfs: The | | | | patch generated 17 new + 994 unchanged - | | | | 23 fixed = 1011 total (was 1017) | +1 | mvnsite | 0m 29s | the patch passed | +1 | mvneclipse | 0m 8s | the patch passed | +1 | whitespace | 0m 0s | The patch has no whitespace issues. | +1 | xml | 0m 1s | The patch has no ill-formed XML file. | +1 | findbugs | 1m 2s | the patch passed | +1 | javadoc | 0m 36s | the patch passed | +1 | unit | 201m 0s | hadoop-hdfs in the patch passed. | +1 | asflicense | 0m 12s | The patch does not generate ASF License | | | | warnings. | | | 212m 21s | was (Author: arpitagarwal): Attached a patch for branch-2. [~xyao], can you please take a look at the patch. The main difference from trunk is that in branch-2 DatasetVolumeChecker returns Set whereas in trunk it returns Set. The difference is that due to branch divergence, we cannot get the StorageLocation from an FsVolumeSpi trivially in branch-2. I ran test-patch locally and results are below. Also tested the branch-2 patch by simulating disk failure and verifying that the failure was caught and the volume was removed. | Vote | Subsystem | Runtime | Comment ============================================================================ | +1 | @author | 0m 0s | The patch does not contain any @author | | | | tags. | +1 | test4tests | 0m 0s | The patch appears to include 20 new or | | | | modified test files. | +1 | mvninstall | 3m 31s | branch-2 passed | +1 | compile | 0m 26s | branch-2 passed | +1 | checkstyle | 0m 29s | branch-2 passed | +1 | mvnsite | 0m 31s | branch-2 passed | +1 | mvneclipse | 0m 11s | branch-2 passed | +1 | findbugs | 0m 59s | branch-2 passed | +1 | javadoc | 0m 38s | branch-2 passed | +1 | mvninstall | 0m 26s | the patch passed | +1 | compile | 0m 23s | the patch passed | +1 | javac | 0m 23s | the patch passed | -1 | checkstyle | 0m 26s | hadoop-hdfs-project/hadoop-hdfs: The | | | | patch generated 17 new + 994 unchanged - | | | | 23 fixed = 1011 total (was 1017) | +1 | mvnsite | 0m 29s | the patch passed | +1 | mvneclipse | 0m 8s | the patch passed | +1 | whitespace | 0m 0s | The patch has no whitespace issues. | +1 | xml | 0m 1s | The patch has no ill-formed XML file. | +1 | findbugs | 1m 2s | the patch passed | +1 | javadoc | 0m 36s | the patch passed | +1 | unit | 201m 0s | hadoop-hdfs in the patch passed. | +1 | asflicense | 0m 12s | The patch does not generate ASF License | | | | warnings. | | | 212m 21s | > Update DataNode to use DatasetVolumeChecker > ------------------------------------------- > > Key: HDFS-11182 > URL: https://issues.apache.org/jira/browse/HDFS-11182 > Project: Hadoop HDFS > Issue Type: Sub-task > Components: datanode > Reporter: Arpit Agarwal > Assignee: Arpit Agarwal > Fix For: 3.0.0-alpha2 > > Attachments: HDFS-11182-branch-2.01.patch > > > Update DataNode to use the DatasetVolumeChecker class introduced in HDFS-11149 to parallelize disk checks. -- This message was sent by Atlassian JIRA (v6.3.4#6332) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org