hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Manoj Govindassamy (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (HDFS-11296) Maintenance state expiry should be an epoch time and not jvm monotonic
Date Thu, 19 Jan 2017 19:48:26 GMT

     [ https://issues.apache.org/jira/browse/HDFS-11296?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel

Manoj Govindassamy updated HDFS-11296:
    Attachment: HDFS-11296.02.patch

Thanks for the review [~mingma] and [~eddyxu]. 

Attached 02 patch with System.currentTimeMillis() replaced with the util Time.now(). Kindly
take a look.

> Maintenance state expiry should be an epoch time and not jvm monotonic
> ----------------------------------------------------------------------
>                 Key: HDFS-11296
>                 URL: https://issues.apache.org/jira/browse/HDFS-11296
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>    Affects Versions: 3.0.0-alpha1
>            Reporter: Manoj Govindassamy
>            Assignee: Manoj Govindassamy
>         Attachments: HDFS-11296.01.patch, HDFS-11296.02.patch, HDFS-11296-branch-2.01.patch,
> Currently it is possible to configure an expiry time in milliseconds for a DataNode in
maintenance state. As per the design, the expiry attribute is an absolute time, beyond which
NameNode starts to stop the ongoing maintenance operation for that DataNode. Internally in
the code, this expiry time is read and checked against {{Time.monotonicNow()}} making the
expiry based on more of JVM's runtime, which is very difficult to configure for any external
user. The goal is to make the expiry time an absolute epoch time, so that its easy to configure
for external users.
> {noformat}
> {
>     "hostName": <host>,
>     "port": <port>,
>     "adminState": "IN_MAINTENANCE",
>     "maintenanceExpireTimeInMS": <time in millis>
> }
> {noformat}
> DatanodeInfo.java
> {noformat}
>   public static boolean maintenanceNotExpired(long maintenanceExpireTimeInMS) {
>     return Time.monotonicNow() < maintenanceExpireTimeInMS;
>   }
> {noformat}

This message was sent by Atlassian JIRA

To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org

View raw message