hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jiajia Li (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-11221) Have StorageDirectory return Optional<File> instead of File/null
Date Mon, 09 Jan 2017 13:05:58 GMT

    [ https://issues.apache.org/jira/browse/HDFS-11221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15811729#comment-15811729
] 

Jiajia Li commented on HDFS-11221:
----------------------------------

Thanks for the detailed and clear explanation, with both two functions is a good idea.

> Have StorageDirectory return Optional<File> instead of File/null
> ----------------------------------------------------------------
>
>                 Key: HDFS-11221
>                 URL: https://issues.apache.org/jira/browse/HDFS-11221
>             Project: Hadoop HDFS
>          Issue Type: Task
>            Reporter: Ewan Higgs
>            Assignee: Jiajia Li
>            Priority: Minor
>         Attachments: HDFS-11221-v1.patch
>
>
> In HDFS-10675, {{StorageDirectory.root}} can be {{null}} because {{PROVIDED}} storage
locations will not have any directories associated with them. Hence, we need to add checks
to StorageDirectory to make sure we handle this. This would also lead to changes in code that
call {{StorageDirectory.getRoot}}, {{StorageDirectory.getCurrentDir}}, {{StorageDirectory.getVersionFile}}
etc. as the return value can be {{nul}}l (if {{StorageDirectory.root}} is null).
> The proposal to handle this is to change the return type of the above functions to {{Optional<File>}}.
According to my preliminary check, this will result in changes in ~70 places, which is why
it's not appropriate to put it in the patch for HDFS-10675. But it is certainly a valuable
fix.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org


Mime
View raw message