hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Rakesh R (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-11186) [SPS]: Daemon thread of SPS should start only in Active NN
Date Wed, 11 Jan 2017 06:05:58 GMT

    [ https://issues.apache.org/jira/browse/HDFS-11186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15817315#comment-15817315
] 

Rakesh R commented on HDFS-11186:
---------------------------------

Thank you [~zhouwei] for the updates. I'm almost OK with the changes. Just few minor comments,
please take care.
# Could you change the word {{inactive}} with proper NN state like,
{code}
      throw new ReconfigurationException(property, newVal,
          getConf().get(property), new HadoopIllegalArgumentException(
          "Activating or deactivating storage policy satisfier service on "
              + state + " NameNode is not allowed"));
{code}
# I just mentioned {{e.printStackTrace();}} as an example in my previous comment. It would
be good to change with proper assertion as shown below:
{code}
      } catch (ReconfigurationException e) {
        GenericTestUtils.assertExceptionContains("Could not change property "
            + DFSConfigKeys.DFS_STORAGE_POLICY_SATISFIER_ACTIVATE_KEY
            + " from 'true' to 'false'", e);
        GenericTestUtils.assertExceptionContains(
            "Activating or deactivating storage policy satisfier service on "
                + "standby NameNode is not allowed", e.getCause());
      }
{code}

bq. Do you mean that it's better to create another jira to change the timeout values instead
of modifying it in this patch? If so, I'll re-update the patch. 
Yeah, since this is not introduced as part of this jira, I'd prefer to raise a separate task
to address the timeout case. Please remove those changes from this patch.

> [SPS]: Daemon thread of SPS should start only in Active NN
> ----------------------------------------------------------
>
>                 Key: HDFS-11186
>                 URL: https://issues.apache.org/jira/browse/HDFS-11186
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: datanode, namenode
>            Reporter: Wei Zhou
>            Assignee: Wei Zhou
>         Attachments: HDFS-11186-HDFS-10285.00.patch, HDFS-11186-HDFS-10285.01.patch,
HDFS-11186-HDFS-10285.02.patch, HDFS-11186-HDFS-10285.03.patch
>
>
> As discussed in [HDFS-10885 |https://issues.apache.org/jira/browse/HDFS-10885], we need
to ensure that SPS is started only in Active NN. This JIRA is opened for discussion and tracking.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org


Mime
View raw message