hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Rakesh R (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-11186) [SPS]: Daemon thread of SPS should start only in Active NN
Date Mon, 02 Jan 2017 11:05:58 GMT

    [ https://issues.apache.org/jira/browse/HDFS-11186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15792685#comment-15792685
] 

Rakesh R commented on HDFS-11186:
---------------------------------

Agreed, not required to change the default value. Probably, we could observe the impact of
this additional thread.join(3000) timeout and raise a separate improvement task(if any changes
needed).

I could see {{NameNode#reconfigureSPSActivate()}} call is not protected and allowing to activate
SPS via dynamic reconfiguration(HDFS-11123) even if NN is in Standby state. Can we add an
extra check {{NN#isActiveState()}} before SPS activation?
{code}
# Test case to dyna switch on SPS

      // NN transits from Active to Standby
      cluster.transitionToStandby(0);
      try {
        cluster.getNameNode(0).reconfigureProperty(
            org.apache.hadoop.hdfs.DFSConfigKeys.DFS_STORAGE_POLICY_SATISFIER_ACTIVATE_KEY,
"true");
      } catch (ReconfigurationException e) {
        e.printStackTrace();
      }
{code}

> [SPS]: Daemon thread of SPS should start only in Active NN
> ----------------------------------------------------------
>
>                 Key: HDFS-11186
>                 URL: https://issues.apache.org/jira/browse/HDFS-11186
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: datanode, namenode
>            Reporter: Wei Zhou
>            Assignee: Wei Zhou
>         Attachments: HDFS-11186-HDFS-10285.00.patch, HDFS-11186-HDFS-10285.01.patch,
HDFS-11186-HDFS-10285.02.patch
>
>
> As discussed in [HDFS-10885 |https://issues.apache.org/jira/browse/HDFS-10885], we need
to ensure that SPS is started only in Active NN. This JIRA is opened for discussion and tracking.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org


Mime
View raw message