hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Wei Zhou (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (HDFS-11170) Add create API in filesystem public class to support assign parameter through builder
Date Wed, 11 Jan 2017 02:32:58 GMT

     [ https://issues.apache.org/jira/browse/HDFS-11170?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Wei Zhou updated HDFS-11170:
----------------------------
    Attachment: HDFS-11170-01.patch

Hi [~andrew.wang], thanks for reviewing the patch and the great suggestions!
The patch is updated with some issues:
{code}
a factory method in FileSystem to get the FS-specific builder?
{code}
I added a function {{newCreateBuilder}} in {{FileSystem}} to generate specific file system
create builder, I'm not sure it proper to do it in this way or not.

{code}
add a new private DFS#create that takes checksumOpt and flags along with favoredNodes is set.
{code}
Do you mean all the {{create}} functions in {{DistributedFileSystem}} goes down to the same
private DFS#create? If so, I found there are some difference in implementation between {{create(...,
final InetSocketAddress[] favoredNodes)}} and {{create(..., final ChecksumOpt checksumOpt)}}.

Thanks again!


> Add create API in filesystem public class to support assign parameter through builder
> -------------------------------------------------------------------------------------
>
>                 Key: HDFS-11170
>                 URL: https://issues.apache.org/jira/browse/HDFS-11170
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>            Reporter: SammiChen
>            Assignee: Wei Zhou
>         Attachments: HDFS-11170-00.patch, HDFS-11170-01.patch
>
>
> FileSystem class supports multiple create functions to help user create file. Some create
functions has many parameters, it's hard for user to exactly remember these parameters and
their orders. This task is to add builder  based create functions to help user more easily
create file. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org


Mime
View raw message