hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dilaver (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-10899) Add functionality to re-encrypt EDEKs.
Date Fri, 06 Jan 2017 21:10:58 GMT

    [ https://issues.apache.org/jira/browse/HDFS-10899?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15805748#comment-15805748
] 

Dilaver commented on HDFS-10899:
--------------------------------

Thanks for the changes Xiao. Some comments about patch 04:

{quote}
    LOG.info("{} removed from re-encrypt queue {} when removing the zone.",
        result ? "Also " : "Did not", inode.getId(), reencryptionStatus);
{quote}
In {{EncryptionZoneManager#removeEncryptionZone}}:
- the format string has 2 placeholders, but 3 args
- I'd suggest moving "removed" into the arg as {{? "Also removed" : "Did not remove"}}
- it may be useful to log the inode name or path in addition to or instead of the Id

{quote}
    // Verify the same is true after NN restart
{quote}
Not sure if this comment is needed ({{TestEncryptionZones#restartClusterDisableReencrypt}}).

Typos in {{ReencryptionHandler#run}}: "reties", "maxRetires".

> Add functionality to re-encrypt EDEKs.
> --------------------------------------
>
>                 Key: HDFS-10899
>                 URL: https://issues.apache.org/jira/browse/HDFS-10899
>             Project: Hadoop HDFS
>          Issue Type: New Feature
>          Components: encryption, kms
>            Reporter: Xiao Chen
>            Assignee: Xiao Chen
>         Attachments: HDFS-10899.01.patch, HDFS-10899.02.patch, HDFS-10899.03.patch, HDFS-10899.04.patch,
HDFS-10899.wip.2.patch, HDFS-10899.wip.patch, Re-encrypt edek design doc.pdf
>
>
> Currently when an encryption zone (EZ) key is rotated, it only takes effect on new EDEKs.
We should provide a way to re-encrypt EDEKs after the EZ key rotation, for improved security.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org


Mime
View raw message