hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "John Zhuge (JIRA)" <j...@apache.org>
Subject [jira] (HDFS-10860) Switch HttpFS from Tomcat to Jetty
Date Tue, 31 Jan 2017 17:07:51 GMT

    [ https://issues.apache.org/jira/browse/HDFS-10860?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15847137#comment-15847137
] 

John Zhuge commented on HDFS-10860:
-----------------------------------

Thanks [~xiaochen] for the review.

bq. HttpFSAuthenticationFilter.java: CONF_PREFIX can be package private

Fixed

bq. MDCFilter:java: why do we need to check getPathInfo() being null here? Do we need to check
other params?

GOT NPE without the check for daemonlog request

ServerSetup.md.vm:
bq. NOTE: The script `httpfs.sh` is deprecated. It is now just a wrapper of `hdfs httpfs`.
I think it's more accurate to say it's a wrapper of hdfs (which is the script being called)?

`httpfs.sh` is a wrapper of `hdfs httpfs`, not `hdfs` which has many other sub-commands.

bq. keytool -genkey -alias tomcat -keyalg RSA let's say bye-bye to tomcat...

Fixed

bq. It seems the paragraph under the keytool line doesn't need the change. Since the example
is given 'As the `httpfs` Unix user'.

Fixed

bq. Let's also have a note in the doc that tomcat is deprecated, together with its old .sh
configurations. We can point to the Deprecated Environment Variables section you added later,
to give more context.

Fixed in section 'Start/Stop HttpFS'

bq. In Deprecated Environment Variables, please move HTTPFS_TEMP to the first line to be consistent
with the config code, and to better group the 'Configuration File'

Variables are sorted by name but ok with your suggestion.

bq. TestHttpFSServerWebServer.java: I was thinking to add a basic test, to do a simple request
after startup, to make sure the server is reachable.

Added to {{TestStartStop}}

bq. index.html: This line doesn't look right /webhdfs/v1/?op=LISTSTATUS to list all keys

Fixed :)

bq. Sorry should have asked this in the KMS jira. The new index.html page for loglevel/jmx/conf/logs
looks nice and handy. But how does the security work here? Have you tested this in a kerberized
environment? I tried locally in a pseudo-authenticated setup, it seems I can read/set everything
even without the user.name= param.

Will investigate

> Switch HttpFS from Tomcat to Jetty
> ----------------------------------
>
>                 Key: HDFS-10860
>                 URL: https://issues.apache.org/jira/browse/HDFS-10860
>             Project: Hadoop HDFS
>          Issue Type: New Feature
>          Components: httpfs
>    Affects Versions: 2.6.0
>            Reporter: John Zhuge
>            Assignee: John Zhuge
>         Attachments: HDFS-10860.001.patch, HDFS-10860.002.patch, HDFS-10860.003.patch,
HDFS-10860.004.patch, HDFS-10860.005.patch, HDFS-10860.006.patch
>
>
> The Tomcat 6 we are using will reach EOL at the end of 2017. While there are other good
options, I would propose switching to {{Jetty 9}} for the following reasons:
> * Easier migration. Both Tomcat and Jetty are based on {{Servlet Containers}}, so we
don't have to change client code that much. It would require more work to switch to {{JAX-RS}}.
> * Well established.
> * Good performance and scalability.
> Other alternatives:
> * Jersey + Grizzly
> * Tomcat 8
> Your opinions will be greatly appreciated.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org


Mime
View raw message