hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Brahma Reddy Battula (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-9935) Remove LEASE_{SOFTLIMIT,HARDLIMIT}_PERIOD and unused import from HdfsServerConstants
Date Wed, 11 Jan 2017 14:10:58 GMT

    [ https://issues.apache.org/jira/browse/HDFS-9935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15818434#comment-15818434
] 

Brahma Reddy Battula commented on HDFS-9935:
--------------------------------------------

bq.If we're sure this change has no compatibility issue, I don't object to get in branch-2.
I feel this should not be problem as these are server side variables and not used..Please
correct me if i am wrong here.


> Remove LEASE_{SOFTLIMIT,HARDLIMIT}_PERIOD and unused import from HdfsServerConstants
> ------------------------------------------------------------------------------------
>
>                 Key: HDFS-9935
>                 URL: https://issues.apache.org/jira/browse/HDFS-9935
>             Project: Hadoop HDFS
>          Issue Type: Bug
>            Reporter: Yiqun Lin
>            Assignee: Yiqun Lin
>            Priority: Minor
>         Attachments: HDFS-9935.001.patch, HDFS-9935.002.patch
>
>
> In HDFS-9134, it has moved the {{LEASE_SOFTLIMIT_PERIOD}},{{LEASE_HARDLIMIT_PERIOD}}
constants from {{HdfsServerConstants}} to {{HdfsConstants}} because these two constants are
used by {{DFSClient}} which is moved to {{hadoop-hdfs-client}}. And constants in {{HdfsConstants}}
can be both used by client and server side. In addition, I have checked that these two constants
in {{HdfsServerConstants}} has already not been used in project now and were all replaced
by {{HdfsConstants.LEASE_SOFTLIMIT_PERIOD}},{{HdfsConstants.LEASE_HARDLIMIT_PERIOD}}. So I
think we can remove these unused constant values in {{HdfsServerConstants}} completely. Instead
of we can use them in {{HdfsConstants}} if we want to use them in the future.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org


Mime
View raw message