Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Date: Tue, 20 Dec 2016 03:28:58 +0000 (UTC)
From: "ASF GitHub Bot (JIRA)" <jira@apache.org>
To: hdfs-issues@hadoop.apache.org
Message-ID: <JIRA.13023870.1480368797000.559761.1482204538602@Atlassian.JIRA>
In-Reply-To: <JIRA.13023870.1480368797000@Atlassian.JIRA>
References: <JIRA.13023870.1480368797000@Atlassian.JIRA> <JIRA.13023870.1480368797856@arcas>
Subject: [jira] [Commented] (HDFS-11182) Update DataNode to use
 DatasetVolumeChecker
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Tue, 20 Dec 2016 03:29:05 -0000


    [ https://issues.apache.org/jira/browse/HDFS-11182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15763091#comment-15763091 ] 

ASF GitHub Bot commented on HDFS-11182:
---------------------------------------

Github user xiaoyuyao commented on a diff in the pull request:

    https://github.com/apache/hadoop/pull/168#discussion_r93166028
  
    --- Diff: hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataNode.java ---
    @@ -2051,14 +2044,13 @@ public void shutdown() {
        * Check if there is a disk failure asynchronously and if so, handle the error
        */
       public void checkDiskErrorAsync() {
    -    synchronized(checkDiskErrorMutex) {
    -      checkDiskErrorFlag = true;
    -      if(checkDiskErrorThread == null) {
    -        startCheckDiskErrorThread();
    -        checkDiskErrorThread.start();
    -        LOG.info("Starting CheckDiskError Thread");
    -      }
    -    }
    +    volumeChecker.checkAllVolumesAsync(
    +        data, (healthyVolumes, failedVolumes) -> {
    +          LOG.info("checkDiskErrorAsync callback got {} failed volumes: {}",
    +              failedVolumes.size(), failedVolumes);
    +          lastDiskErrorCheck = Time.monotonicNow();
    --- End diff --
    
    should this be timer.monotonicNow();


> Update DataNode to use DatasetVolumeChecker
> -------------------------------------------
>
>                 Key: HDFS-11182
>                 URL: https://issues.apache.org/jira/browse/HDFS-11182
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: datanode
>            Reporter: Arpit Agarwal
>            Assignee: Arpit Agarwal
>
> Update DataNode to use the DatasetVolumeChecker class introduced in HDFS-11149 to parallelize disk checks.


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org