Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Date: Tue, 6 Dec 2016 01:35:58 +0000 (UTC)
From: "Andrew Wang (JIRA)" <jira@apache.org>
To: hdfs-issues@hadoop.apache.org
Message-ID: <JIRA.12830106.1431677417000.445122.1480988158363@Atlassian.JIRA>
In-Reply-To: <JIRA.12830106.1431677417000@Atlassian.JIRA>
References: <JIRA.12830106.1431677417000@Atlassian.JIRA> <JIRA.12830106.1431677417340@arcas>
Subject: [jira] [Commented] (HDFS-8411) Add bytes count metrics to datanode
 for ECWorker
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Tue, 06 Dec 2016 01:36:00 -0000


    [ https://issues.apache.org/jira/browse/HDFS-8411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15723974#comment-15723974 ] 

Andrew Wang commented on HDFS-8411:
-----------------------------------

Thanks for working on this Sammi and Rakesh for reviewing, I had a few additional comments/questions:

* In StripedReader, bytesRead is incremented when the future is submitted. However, we don't know if the future has succeeded until later on. Seems like we should increment only for successful requests?
* Why don't we increment the metrics directly in StripedReader / StripedWriter rather than doing it in StripedBlockReconstructor?
* If we aren't going to handle remote vs. local reconstruction targets in this JIRA, could you file a new JIRA to track this as a follow-on? It's pretty important, especially since on the destination side, it gets lumped together with other OP_WRITE calls.

> Add bytes count metrics to datanode for ECWorker
> ------------------------------------------------
>
>                 Key: HDFS-8411
>                 URL: https://issues.apache.org/jira/browse/HDFS-8411
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>            Reporter: Li Bo
>            Assignee: SammiChen
>         Attachments: HDFS-8411-001.patch, HDFS-8411-002.patch, HDFS-8411-003.patch, HDFS-8411-004.patch, HDFS-8411-005.patch, HDFS-8411-006.patch, HDFS-8411-007.patch, HDFS-8411-008.patch, HDFS-8411-009.patch
>
>
> This is a sub task of HDFS-7674. It calculates the amount of data that is read from local or remote to attend decoding work, and also the amount of data that is written to local or remote datanodes.


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org