hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Akira Ajisaka (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-11262) Remove unused variable in FSImage.java
Date Mon, 19 Dec 2016 18:55:58 GMT

    [ https://issues.apache.org/jira/browse/HDFS-11262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15761991#comment-15761991
] 

Akira Ajisaka commented on HDFS-11262:
--------------------------------------

Nice catch! Yes, it should be removed.

> Remove unused variable in FSImage.java
> --------------------------------------
>
>                 Key: HDFS-11262
>                 URL: https://issues.apache.org/jira/browse/HDFS-11262
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>            Reporter: Akira Ajisaka
>            Assignee: Jagadesh Kiran N
>            Priority: Trivial
>              Labels: newbie
>         Attachments: HDFS-11262_00.patch, HDFS-11262_01.patch
>
>
> {code:title=FSImage.java}
>     Exception le = null;
>     FSImageFile imageFile = null;
>     for (int i = 0; i < imageFiles.size(); i++) {
>       try {
>         imageFile = imageFiles.get(i);
>         loadFSImageFile(target, recovery, imageFile, startOpt);
>         break;
>       } catch (IllegalReservedPathException ie) {
>         throw new IOException("Failed to load image from " + imageFile,
>             ie);
>       } catch (Exception e) {
>         le = e;
>         LOG.error("Failed to load image from " + imageFile, e);
>         target.clear();
>         imageFile = null;
>       }
>     }
> {code}
> Exception {{le}} is not used. It can be removed.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org


Mime
View raw message