hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mingliang Liu (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (HDFS-11253) FileInputStream leak on failure path in BlockSender
Date Thu, 15 Dec 2016 23:44:58 GMT

     [ https://issues.apache.org/jira/browse/HDFS-11253?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Mingliang Liu updated HDFS-11253:
---------------------------------
       Resolution: Fixed
     Hadoop Flags: Reviewed
    Fix Version/s: 3.0.0-alpha2
           Status: Resolved  (was: Patch Available)

United failure is not related. Checkstyle warning is mostly caused by existing code. We don't
need new unit test for this case as existing ones are sufficient.

Committed to {{trunk}}. Thanks [~arpitagarwal] for your contribution.

> FileInputStream leak on failure path in BlockSender
> ---------------------------------------------------
>
>                 Key: HDFS-11253
>                 URL: https://issues.apache.org/jira/browse/HDFS-11253
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: datanode
>            Reporter: Arpit Agarwal
>            Assignee: Arpit Agarwal
>             Fix For: 3.0.0-alpha2
>
>         Attachments: HDFS-11253.01.patch
>
>
> The BlockSender constructor should close the blockIn and checksumIn streams here:
> {code}
> 405:       blockIn = datanode.data.getBlockInputStream(block, offset); // seek to offset
> 406:       ris = new ReplicaInputStreams(
> 407:           blockIn, checksumIn, volumeRef, fileIoProvider);
> 408:     } catch (IOException ioe) {
> 409:       IOUtils.closeStream(this);
> 410:       throw ioe;
> 411:     }
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org


Mime
View raw message