hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Steve Loughran (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (HDFS-11228) Remove deprecated FileSystem#getDefault* and getServerDefault methods that don't take a Path argument
Date Fri, 09 Dec 2016 12:43:58 GMT

    [ https://issues.apache.org/jira/browse/HDFS-11228?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15735218#comment-15735218
] 

Steve Loughran edited comment on HDFS-11228 at 12/9/16 12:43 PM:
-----------------------------------------------------------------

-1

# There's almost no cost in these methods, as they return the defaults. It's mainly in viewFS
that you may have different defaults on different paths.
# If you look at implementations {{getServerDefaults(Path)}} defaults to calling {{getServerDefaults()}}
—which is the implementation provided by most of the filesystem implementations.
# remove that base method and it potentially breaks every FS implementation, who will have
to now implement {{getServerDefaults(Path)}}, and, if they did implement {{getServerDefaults()}},
either remove it, or at least remove any {{@Override}} marker.

This is not just going to cause problems client-side, it will break those implementations.

(moving to HDFS as it's an FS API issue, which makes it their responsibility)


was (Author: stevel@apache.org):
-1

# There's almost no cost in these methods, as they return the defaults. It's mainly in viewFS
that you may have different defaults.
# If you look at implementations {{getServerDefaults(Path)}} defaults to calling {{getServerDefaults()}}
—which is the implementation provided by most of the filesystem implementations.
# remove that base method and it potentially breaks every FS implementation, who will have
to now implement {{getServerDefaults(Path)}}, and, if they did implement {{getServerDefaults()}},
either remove it, or at least remove any {{@Override}} marker.

This is not just going to cause problems client-side, it will break those implementations.

(moving to HDFS as it's an FS API issue, which makes it their responsibility)

> Remove deprecated FileSystem#getDefault* and getServerDefault methods that don't take
a Path argument 
> ------------------------------------------------------------------------------------------------------
>
>                 Key: HDFS-11228
>                 URL: https://issues.apache.org/jira/browse/HDFS-11228
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: fs
>            Reporter: Akira Ajisaka
>            Assignee: Akira Ajisaka
>            Priority: Minor
>         Attachments: HADOOP-13879.01.patch, HADOOP-13879.02.patch, HADOOP-13879.03.patch,
HADOOP-13879.04.patch
>
>
> FileSystem#getServerDefaults(), #getDefaultReplication, #getDefaultBlockSize were deprecated
by HADOOP-8422 and the fix version is 2.0.2-alpha. They can be removed in Hadoop 3.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org


Mime
View raw message