hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Andrew Wang (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-11217) Make some JMX interfaces private
Date Wed, 07 Dec 2016 21:40:58 GMT

    [ https://issues.apache.org/jira/browse/HDFS-11217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15729998#comment-15729998
] 

Andrew Wang commented on HDFS-11217:
------------------------------------

I think the rationale is that end users shouldn't be implementing these interfaces, and instead
access this information through the JMX APIs. The JMX APIs are public and stable, not these
Java interfaces.

So, I think something like "private/stable" is the correct designation, with a comment explaining
the above. I think it's unlikely that any external code is implementing these interfaces.

> Make some JMX interfaces private
> --------------------------------
>
>                 Key: HDFS-11217
>                 URL: https://issues.apache.org/jira/browse/HDFS-11217
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>            Reporter: Akira Ajisaka
>            Assignee: Jagadesh Kiran N
>
> NameNodeMXBean, NameNodeStatusMXBean, DataNodeMXBean are annotated {{@Public}} and {{@Stable}},
but some methods are being added. For example, DataNodeMXBean.getBPServiceActorInfo was added
between branch-2.7.3 and branch-2.8. Adding methods to interfaces breaks the user classes
which implement them, so we should make them {{@Private}}.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org


Mime
View raw message