hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Anu Engineer (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-11217) Make some JMX interfaces private
Date Wed, 07 Dec 2016 19:01:58 GMT

    [ https://issues.apache.org/jira/browse/HDFS-11217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15729620#comment-15729620
] 

Anu Engineer commented on HDFS-11217:
-------------------------------------

bq. Adding methods to interfaces breaks the user classes which implement them, so we should
make them @Private

Wouldn't making them private a bigger violation of the contract ? I agree it might not break
the end user application, but they might not even realize that we have changed the suggested
access method. 

Unfortunately, I don't have a better suggestion than yourself on how to fix this issue.


> Make some JMX interfaces private
> --------------------------------
>
>                 Key: HDFS-11217
>                 URL: https://issues.apache.org/jira/browse/HDFS-11217
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>            Reporter: Akira Ajisaka
>            Assignee: Jagadesh Kiran N
>
> NameNodeMXBean, NameNodeStatusMXBean, DataNodeMXBean are annotated {{@Public}} and {{@Stable}},
but some methods are being added. For example, DataNodeMXBean.getBPServiceActorInfo was added
between branch-2.7.3 and branch-2.8. Adding methods to interfaces breaks the user classes
which implement them, so we should make them {{@Private}}.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org


Mime
View raw message