hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Chris Nauroth (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (HDFS-9911) TestDataNodeLifeline Fails intermittently
Date Wed, 14 Dec 2016 06:48:58 GMT

     [ https://issues.apache.org/jira/browse/HDFS-9911?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Chris Nauroth updated HDFS-9911:
--------------------------------
    Assignee: Yiqun Lin  (was: Chris Nauroth)

[~linyiqun], thank you for the analysis and volunteering to take over the patch.  I am reassigning
this to you.

I suggest changing this to:

{code}
scheduleNextLifeline(nextHeartbeatTime);
{code}

This would make it consistent with other points in the code where the lifeline time is scheduled
relative to the heartbeat time.  It could help avoid confusion if 2 separate calls to {{monotonicNow()}}
return 2 different timestamps (one for initialization of {{nextHeartbeatTime}} and the other
for {{scheduleNextLifeline}}).

> TestDataNodeLifeline  Fails intermittently
> ------------------------------------------
>
>                 Key: HDFS-9911
>                 URL: https://issues.apache.org/jira/browse/HDFS-9911
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: datanode
>    Affects Versions: 2.8.0
>            Reporter: Anu Engineer
>            Assignee: Yiqun Lin
>             Fix For: 2.8.0
>
>         Attachments: HDFS-9911.001.patch
>
>
> In HDFS-1312 branch, we have a failure for this test.
> {{org.apache.hadoop.hdfs.server.datanode.TestDataNodeLifeline.testNoLifelineSentIfHeartbeatsOnTime}}
> {noformat}
> Error Message
> Expect metrics to count no lifeline calls. expected:<0> but was:<1>
> Stacktrace
> java.lang.AssertionError: Expect metrics to count no lifeline calls. expected:<0>
but was:<1>
> 	at org.junit.Assert.fail(Assert.java:88)
> 	at org.junit.Assert.failNotEquals(Assert.java:743)
> 	at org.junit.Assert.assertEquals(Assert.java:118)
> 	at org.junit.Assert.assertEquals(Assert.java:555)
> 	at org.apache.hadoop.hdfs.server.datanode.TestDataNodeLifeline.testNoLifelineSentIfHeartbeatsOnTime(TestDataNodeLifeline.java:256)
> {noformat}
> Details can be found here.
> https://builds.apache.org/job/PreCommit-HDFS-Build/14726/testReport/org.apache.hadoop.hdfs.server.datanode/TestDataNodeLifeline/testNoLifelineSentIfHeartbeatsOnTime/



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org


Mime
View raw message