hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Yiqun Lin (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (HDFS-9911) TestDataNodeLifeline Fails intermittently
Date Wed, 14 Dec 2016 01:43:59 GMT

     [ https://issues.apache.org/jira/browse/HDFS-9911?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel

Yiqun Lin updated HDFS-9911:
    Status: Patch Available  (was: Open)

Post a simple patch here, I hope Chris will not mind that since I see this JIRA has been opened
for a long time.
Here I have two ways to fix this:

* Delay the {{nextLifelineTime}} time and to let heartbeat sended first.
* Use {{DataNode#setHeartbeatsDisabledForTests(true)}} to disabled the heratbeat in {{setup}}
since this also makes sense to disabled lifeline send.

Here I am prefer to use the first way and I think this is enough to fix this. And that's will
make the order of sending messages correct. Softly ping [~anu], could you please have a review?

> TestDataNodeLifeline  Fails intermittently
> ------------------------------------------
>                 Key: HDFS-9911
>                 URL: https://issues.apache.org/jira/browse/HDFS-9911
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: datanode
>    Affects Versions: 2.8.0
>            Reporter: Anu Engineer
>            Assignee: Chris Nauroth
>             Fix For: 2.8.0
> In HDFS-1312 branch, we have a failure for this test.
> {{org.apache.hadoop.hdfs.server.datanode.TestDataNodeLifeline.testNoLifelineSentIfHeartbeatsOnTime}}
> {noformat}
> Error Message
> Expect metrics to count no lifeline calls. expected:<0> but was:<1>
> Stacktrace
> java.lang.AssertionError: Expect metrics to count no lifeline calls. expected:<0>
but was:<1>
> 	at org.junit.Assert.fail(Assert.java:88)
> 	at org.junit.Assert.failNotEquals(Assert.java:743)
> 	at org.junit.Assert.assertEquals(Assert.java:118)
> 	at org.junit.Assert.assertEquals(Assert.java:555)
> 	at org.apache.hadoop.hdfs.server.datanode.TestDataNodeLifeline.testNoLifelineSentIfHeartbeatsOnTime(TestDataNodeLifeline.java:256)
> {noformat}
> Details can be found here.
> https://builds.apache.org/job/PreCommit-HDFS-Build/14726/testReport/org.apache.hadoop.hdfs.server.datanode/TestDataNodeLifeline/testNoLifelineSentIfHeartbeatsOnTime/

This message was sent by Atlassian JIRA

To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org

View raw message