Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Date: Tue, 22 Nov 2016 17:56:58 +0000 (UTC)
From: "Arpit Agarwal (JIRA)" <jira@apache.org>
To: hdfs-issues@hadoop.apache.org
Message-ID: <JIRA.13018629.1478365102000.341096.1479837418976@Atlassian.JIRA>
In-Reply-To: <JIRA.13018629.1478365102000@Atlassian.JIRA>
References: <JIRA.13018629.1478365102000@Atlassian.JIRA> <JIRA.13018629.1478365102828@arcas>
Subject: [jira] [Commented] (HDFS-11112) Journal Nodes should refuse to
 format non-empty directories
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Tue, 22 Nov 2016 17:57:00 -0000


    [ https://issues.apache.org/jira/browse/HDFS-11112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15687419#comment-15687419 ] 

Arpit Agarwal commented on HDFS-11112:
--------------------------------------

Sorry I couldn't respond earlier. [~jojochuang] that is correct, if the format request comes in via RPC then the JN skips the check for non-empty directories.

> Journal Nodes should refuse to format non-empty directories
> -----------------------------------------------------------
>
>                 Key: HDFS-11112
>                 URL: https://issues.apache.org/jira/browse/HDFS-11112
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>            Reporter: Arpit Agarwal
>            Assignee: Yiqun Lin
>         Attachments: HDFS-11112.001.patch, HDFS-11112.002.patch
>
>
> Journal Nodes should reject the {{format}} RPC request if a storage directory is non-empty. The relevant code is in {{JNStorage#format}}.
> {code}
>   void format(NamespaceInfo nsInfo) throws IOException {
>     setStorageInfo(nsInfo);
> ...
>     unlockAll();
>     sd.clearDirectory();
>     writeProperties(sd);
>     createPaxosDir();
>     analyzeStorage();
> {code}
> This would make the behavior similar to {{namenode -format -nonInteractive}}.


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org