Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Date: Sun, 6 Nov 2016 03:38:59 +0000 (UTC)
From: "Xiaoyu Yao (JIRA)" <jira@apache.org>
To: hdfs-issues@hadoop.apache.org
Message-ID: <JIRA.13017953.1478240730000.202150.1478403539218@Atlassian.JIRA>
In-Reply-To: <JIRA.13017953.1478240730000@Atlassian.JIRA>
References: <JIRA.13017953.1478240730000@Atlassian.JIRA> <JIRA.13017953.1478240730957@arcas>
Subject: [jira] [Commented] (HDFS-11103) Ozone: Cleanup some dependencies
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Sun, 06 Nov 2016 03:39:01 -0000


    [ https://issues.apache.org/jira/browse/HDFS-11103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15641052#comment-15641052 ] 

Xiaoyu Yao commented on HDFS-11103:
-----------------------------------

Thanks [~anu] for working on this. The patch looks good to me overall. Just some NITS:
*ContainerLocationManagerImpl.java*
1. Line 55 
{code}
 volumePaths = dataDirs.toArray(new Path[0]); =>dataDirs.toArray(new Path[dataDirs.size()]) 
{code}
Allocate array to the right size to avoid unnecessary reallocate.

2. Can we add some comments for {{volumePaths}} and {{locations}} for example, one for container data and one for container metadata?

*ContainerManagerImpl.java*
3. Extra blank line 95
4. Do you consider maintaining a list of StorageLocation instead a list of Paths inside ContainerLocationManagerImpl so that we can leverage the storage type information from StorageLocation for use case as documented in ContainerLocationMangerImpl.java below. If this causes too much churn across the code base. It is OK to leave this for later with some additional TODOs.
{code}
 *  For example : A user could map all container files to a SSD but leave data/metadata on bunch of other disks.
{code}

> Ozone: Cleanup some dependencies
> --------------------------------
>
>                 Key: HDFS-11103
>                 URL: https://issues.apache.org/jira/browse/HDFS-11103
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: ozone
>    Affects Versions: HDFS-7240
>            Reporter: Anu Engineer
>            Assignee: Anu Engineer
>            Priority: Trivial
>             Fix For: HDFS-7240
>
>         Attachments: HDFS-11103-HDFS-7240.001.patch, HDFS-11103-HDFS-7240.002.patch
>
>
> Cleanup some unwanted dependencies.


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org