Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 58046200BDB for ; Mon, 7 Nov 2016 06:31:00 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 56A19160AFC; Mon, 7 Nov 2016 05:31:00 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id A119F160B0D for ; Mon, 7 Nov 2016 06:30:59 +0100 (CET) Received: (qmail 65613 invoked by uid 500); 7 Nov 2016 05:30:58 -0000 Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list hdfs-issues@hadoop.apache.org Received: (qmail 65541 invoked by uid 99); 7 Nov 2016 05:30:58 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 07 Nov 2016 05:30:58 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id 818742C2A67 for ; Mon, 7 Nov 2016 05:30:58 +0000 (UTC) Date: Mon, 7 Nov 2016 05:30:58 +0000 (UTC) From: "Kai Zheng (JIRA)" To: hdfs-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HDFS-10994) Support an XOR policy XOR-2-1-64k in HDFS MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Mon, 07 Nov 2016 05:31:00 -0000 [ https://issues.apache.org/jira/browse/HDFS-10994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15643174#comment-15643174 ] Kai Zheng commented on HDFS-10994: ---------------------------------- Not relevant to the work here, but just raising some questions by the way, looking at the following codes: {code} public static final byte RS_6_3_POLICY_ID = 0; public static final byte RS_3_2_POLICY_ID = 1; public static final byte RS_6_3_LEGACY_POLICY_ID = 2; + public static final byte XOR_2_1_POLICY_ID = 3; {code} * Suggest we start the {{POLICY_ID}} from 1 instead of 0, to avoid some unexpected errors in codes since 0 is default value for integer variables. I had discussed offline with [~Sammi] about this and the idea sounds good so far. * Maybe we can remove related {{LEGACY_POLICY_ID}} as [~andrew.wang] commented elsewhere we don't need to use any legacy policies in HDFS side, though I want to keep the legacy coders in Hadoop side. How would you think? Maybe [~andrew.wang] and [~zhz] could also give some comments? Thanks. If sounds good to do these, separate issue would be good. > Support an XOR policy XOR-2-1-64k in HDFS > ----------------------------------------- > > Key: HDFS-10994 > URL: https://issues.apache.org/jira/browse/HDFS-10994 > Project: Hadoop HDFS > Issue Type: Sub-task > Components: erasure-coding > Affects Versions: 3.0.0-alpha1 > Reporter: SammiChen > Assignee: SammiChen > Labels: hdfs-ec-3.0-must-do > Attachments: HDFS-10994-v1.patch, HDFS-10994-v2.patch, HDFS-10994-v3.patch > > > So far, "hdfs erasurecode" command supports three policies, RS-DEFAULT-3-2-64k, RS-DEFAULT-6-3-64k and RS-LEGACY-6-3-64k. This task is going to add XOR-2-1-64k policy to this command. -- This message was sent by Atlassian JIRA (v6.3.4#6332) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org