Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 6671B200BD0 for ; Wed, 30 Nov 2016 12:48:01 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 64F87160B13; Wed, 30 Nov 2016 11:48:01 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id B0CBD160B08 for ; Wed, 30 Nov 2016 12:48:00 +0100 (CET) Received: (qmail 46037 invoked by uid 500); 30 Nov 2016 11:47:59 -0000 Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list hdfs-issues@hadoop.apache.org Received: (qmail 46017 invoked by uid 99); 30 Nov 2016 11:47:59 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 30 Nov 2016 11:47:59 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id B26002C1F54 for ; Wed, 30 Nov 2016 11:47:59 +0000 (UTC) Date: Wed, 30 Nov 2016 11:47:59 +0000 (UTC) From: "Steve Loughran (JIRA)" To: hdfs-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HDFS-6262) HDFS doesn't raise FileNotFoundException if the source of a rename() is missing MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Wed, 30 Nov 2016 11:48:01 -0000 [ https://issues.apache.org/jira/browse/HDFS-6262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15708354#comment-15708354 ] Steve Loughran commented on HDFS-6262: -------------------------------------- I concur. the newer rename, which in FileSystem is marked as @Deprecated, does do the check and has a more consistent model. We can undeprecate it (it was deprecated because it was "transitionary" to FileContext), move code to it > HDFS doesn't raise FileNotFoundException if the source of a rename() is missing > ------------------------------------------------------------------------------- > > Key: HDFS-6262 > URL: https://issues.apache.org/jira/browse/HDFS-6262 > Project: Hadoop HDFS > Issue Type: Bug > Components: namenode > Affects Versions: 2.4.0 > Reporter: Steve Loughran > Assignee: Akira Ajisaka > Labels: BB2015-05-TBR > Attachments: HDFS-6262.2.patch, HDFS-6262.patch > > > HDFS's {{rename(src, dest)}} returns false if src does not exist -all the other filesystems raise {{FileNotFoundException}} > This behaviour is defined in {{FSDirectory.unprotectedRenameTo()}} -the attempt is logged, but the operation then just returns false. > I propose changing the behaviour of {{DistributedFileSystem}} to be the same as that of the others -and of {{FileContext}}, which does reject renames with nonexistent sources -- This message was sent by Atlassian JIRA (v6.3.4#6332) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org