hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Anu Engineer (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-11149) Support for parallel checking of FsVolumes
Date Tue, 29 Nov 2016 19:32:59 GMT

    [ https://issues.apache.org/jira/browse/HDFS-11149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15706299#comment-15706299

Anu Engineer commented on HDFS-11149:

[~arpitagarwal] Thanks for the patch. It looks quite good overall. I had one minor question.

In {{checkAllVolumes}} we hold on to a volume.
  for (int i = 0; i < references.size(); ++i) {
      final FsVolumeReference reference = references.getReference(i);
      ListenableFuture<VolumeCheckResult> future =
          delegateChecker.schedule(reference.getVolume(), true);
      LOG.info("Scheduled health check for volume {}", reference.getVolume());
      Futures.addCallback(future, new ResultHandler(
          reference, healthyVolumes, failedVolumes, resultsLatch, null));

How does this play with the ability to remove disks, do you think this can be an issue ?

ps. Test failures does not seem to be from this patch but you might want to fix the last checkstyle

> Support for parallel checking of FsVolumes
> ------------------------------------------
>                 Key: HDFS-11149
>                 URL: https://issues.apache.org/jira/browse/HDFS-11149
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: datanode
>            Reporter: Arpit Agarwal
>            Assignee: Arpit Agarwal
>         Attachments: HDFS-11149.01.patch, HDFS-11149.02.patch, HDFS-11149.03.patch, HDFS-11149.04.patch,
HDFS-11149.05.patch, HDFS-11149.06.patch, HDFS-11149.07.patch, HDFS-11149.08.patch, HDFS-11149.09.patch,
> Similar to HDFS-11119, the DataNode can parallelize checking FsVolumes.

This message was sent by Atlassian JIRA

To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org

View raw message