hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Chen Liang (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-11147) Remove confusing log output in FsDatasetImpl#getInitialVolumeFailureInfos
Date Wed, 16 Nov 2016 22:42:58 GMT

    [ https://issues.apache.org/jira/browse/HDFS-11147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15671906#comment-15671906
] 

Chen Liang commented on HDFS-11147:
-----------------------------------

The failed tests are unrelated.

> Remove confusing log output in FsDatasetImpl#getInitialVolumeFailureInfos
> -------------------------------------------------------------------------
>
>                 Key: HDFS-11147
>                 URL: https://issues.apache.org/jira/browse/HDFS-11147
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: datanode
>            Reporter: Chen Liang
>            Assignee: Chen Liang
>            Priority: Minor
>         Attachments: HDFS-11147.001.patch
>
>
> In {{FsDatasetImpl}} the method {{getInitialVolumeFailureInfos}} there is 
> {code}
> for (StorageLocation sl: dataLocations) {
>       LOG.info("Adding to failedLocationSet " + sl);
>       failedLocationSet.add(sl);
>     }
>     for (Iterator<Storage.StorageDirectory> it = storage.dirIterator();
>          it.hasNext(); ) {
>       Storage.StorageDirectory sd = it.next();
>       failedLocationSet.remove(sd.getStorageLocation());
>       LOG.info("Removing from failedLocationSet " + sd.getStorageLocation());
>     }
> }
> {code}
> The log messages here can be confusing as it may prints "Adding to failedLocationSet"
message, which looks like a failure is happening, but later on removed the storage location
from failedLocationSet. We should just remove these two log messages.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org


Mime
View raw message