hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Arpit Agarwal (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-11119) Support for parallel checking of StorageLocations on DataNode startup
Date Wed, 09 Nov 2016 22:56:58 GMT

    [ https://issues.apache.org/jira/browse/HDFS-11119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15652303#comment-15652303
] 

Arpit Agarwal commented on HDFS-11119:
--------------------------------------

Thank you for the review [~anu]. I have updated the PR with a commit to address your comments.
A few responses below:
# bq. This is milliseconds right ? but if that is hardcoded in code, then why take an "m"
if all of these are time units in milliseconds.
bq. In hdfs-default.xml also can we specify that the time unit is in milliseconds.
We use Configuration#getTimeDuration which supports suffixes for common time units (m implies
minutes). However you are right that this is not at all obvious. I updated the descriptions
in hdfs-default.xml with pointers to the list of supported suffixes.
# bq. Should we Log.error this case too ?
Good point. This error is logged as a fatal exception by the DataNode so we shouldn't need
a separate message. I made the behavior consistent for both failure cases. Let me know what
you think.
# bq.  Can we take a ThreadFactory so we can set the name of threads in this pool ? Plus,
Are these threads daemons ? 
Good catch. Fixed both points.
# bq. nit : I am presuming the change in Datanode startup is coming in a later patch ? 
Correct.

> Support for parallel checking of StorageLocations on DataNode startup
> ---------------------------------------------------------------------
>
>                 Key: HDFS-11119
>                 URL: https://issues.apache.org/jira/browse/HDFS-11119
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: datanode
>            Reporter: Arpit Agarwal
>            Assignee: Arpit Agarwal
>
> The {{AsyncChecker}} support introduced by HDFS-11114 can be used to parallelize checking
{{StorageLocation}} s on Datanode startup.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org


Mime
View raw message