hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Xiaoyu Yao (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-11108) Ozone: use containers with the state machine
Date Mon, 14 Nov 2016 20:02:59 GMT

    [ https://issues.apache.org/jira/browse/HDFS-11108?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15664862#comment-15664862
] 

Xiaoyu Yao commented on HDFS-11108:
-----------------------------------

Thanks [~anu] for working on this. The patch looks good to me. I just have few minor issues.
Regarding rename the OzoneContainer to SCMContainer, it can be postphoned to later time.


*Datanode.java*
Line 399: NIT: can we name containerStateMachine to datanodeStateMachine?

*DatanodeStateMachine.java*
Line 49 NIT: “OzoneContainer” should be “SCMContainer” but this can be addressed later.

Line 51 NIT:  “  * Constructs a container state machine.” should be “  * Constructs
a datanode state machine.
Line 55 The change of exception declaration is not needed, the InterruptedException | ExecutionException
| TimeoutException
has been caught and IOException is good enough. This also reduces exception declaration changes
in some of the tests to match it.

*TestDatanodeStateMachine.java*
Line 117, 122, 169: changes are not needed.



> Ozone: use containers with the state machine
> --------------------------------------------
>
>                 Key: HDFS-11108
>                 URL: https://issues.apache.org/jira/browse/HDFS-11108
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: ozone
>    Affects Versions: HDFS-7240
>            Reporter: Anu Engineer
>            Assignee: Anu Engineer
>             Fix For: HDFS-7240
>
>         Attachments: HDFS-11108-HDFS-7240.001.patch
>
>
> Use containers via the new added state machine.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org


Mime
View raw message