hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Eric Badger (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-11048) Audit Log should escape control characters
Date Mon, 07 Nov 2016 21:38:58 GMT

    [ https://issues.apache.org/jira/browse/HDFS-11048?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15645543#comment-15645543
] 

Eric Badger commented on HDFS-11048:
------------------------------------

bq. e.g., does '\thisfile' begin with a tab or does it begin with a backlash?
'\thisfile' would begin with a backslash. 

I'm not sure I understand what you mean about the ambiguity. I can think of one pretty contrived
case where I think this might cause less than ideal behavior. If you had a file that started
with a tab followed by "hisfile", it would be printed as "\thisfile" in the audit log. However,
if you had a file called "\thisfile" (where the \t are 2 separate ascii chars), it would also
be printed in the audit log as "\thisfile". 

> Audit Log should escape control characters
> ------------------------------------------
>
>                 Key: HDFS-11048
>                 URL: https://issues.apache.org/jira/browse/HDFS-11048
>             Project: Hadoop HDFS
>          Issue Type: Bug
>            Reporter: Eric Badger
>            Assignee: Eric Badger
>             Fix For: 2.8.0, 3.0.0-alpha2
>
>         Attachments: HDFS-11048.001.patch, HDFS-11048.002.patch
>
>
> Allowing control characters without escaping them allows for spoofing audit log entries
at worst and accidentally breaking log parsing at best.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org


Mime
View raw message