hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Arpit Agarwal (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-10930) Refactor: Wrap Datanode IO related operations
Date Mon, 14 Nov 2016 23:50:58 GMT

    [ https://issues.apache.org/jira/browse/HDFS-10930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15665422#comment-15665422
] 

Arpit Agarwal commented on HDFS-10930:
--------------------------------------

Mirroring comment from Github:

Thanks [~xyao]. The patch looks good overall. Findbugs flagged a few warnings and the TestWriteToReplica
failure looks related.

There's a few remaining static methods like Storage#rename, and DatanodeUtil#createTmpFile
that aren't as easy to factor out. We can look at them in a subsequent Jira. In a subsequent
change we'll want to move the refactored methods into interfaces for testability.


> Refactor: Wrap Datanode IO related operations
> ---------------------------------------------
>
>                 Key: HDFS-10930
>                 URL: https://issues.apache.org/jira/browse/HDFS-10930
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: datanode
>            Reporter: Xiaoyu Yao
>            Assignee: Xiaoyu Yao
>         Attachments: HDFS-10930.01.patch, HDFS-10930.02.patch, HDFS-10930.03.patch, HDFS-10930.04.patch,
HDFS-10930.05.patch
>
>
> Datanode IO (Disk/Network) related operations and instrumentations are currently spilled
in many classes such as DataNode.java, BlockReceiver.java, BlockSender.java, FsDatasetImpl.java,
FsVolumeImpl.java, DirectoryScanner.java, BlockScanner.java, FsDatasetAsyncDiskService.java,
LocalReplica.java, LocalReplicaPipeline.java, Storage.java, etc. 
> This ticket is opened to consolidate IO related operations for easy instrumentation,
metrics collection, logging and trouble shooting. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org


Mime
View raw message