hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Arpit Agarwal (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-10913) Introduce fault injectors to simulate slow mirrors
Date Tue, 29 Nov 2016 18:37:58 GMT

    [ https://issues.apache.org/jira/browse/HDFS-10913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15706142#comment-15706142

Arpit Agarwal commented on HDFS-10913:

Thanks for this testability improvement [~xiaobingo]. Few comments:
# delayWritingPacketToMirror looks unnecessary as we already have stopSendingPacketDownstream.

# Can you please add a hook for delayWritingChecksumToDisk also here?
# delaySyncingWriterOsCache should not introduce delay when syncBehindWritesInBackground is
enabled. The delay should be in the else clause only in manageWriterOsCache:
          if (syncBehindWritesInBackground) {
          } else {

Also you may have to rebase the patch once HDFS-10930 is committed. Still reviewing the unit

> Introduce fault injectors to simulate slow mirrors
> --------------------------------------------------
>                 Key: HDFS-10913
>                 URL: https://issues.apache.org/jira/browse/HDFS-10913
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: datanode
>    Affects Versions: 2.8.0
>            Reporter: Xiaobing Zhou
>            Assignee: Xiaobing Zhou
>         Attachments: HDFS-10913.000.patch, HDFS-10913.001.patch, HDFS-10913.002.patch,
HDFS-10913.003.patch, HDFS-10913.004.patch
> BlockReceiver#datanodeSlowLogThresholdMs is used as threshold to detect slow mirrors.
BlockReceiver only writes some warning logs. In order to better test behaviors of slow mirrors,
it necessitates introducing fault injectors.

This message was sent by Atlassian JIRA

To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org

View raw message