hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Rakesh R (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-10885) [SPS]: Mover tool should not be allowed to run when Storage Policy Satisfier is on
Date Mon, 28 Nov 2016 18:29:58 GMT

    [ https://issues.apache.org/jira/browse/HDFS-10885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15702726#comment-15702726
] 

Rakesh R commented on HDFS-10885:
---------------------------------

Thanks [~zhouwei] for the good work. I'm +1 for the latest patch after addressing the below
comments.

# Could you mention the default behavior in hdfs-default.xml something like,
{code}
If true, enables StoragePolicySatisfier. By default, StoragePolicySatisfier is enabled.
{code}
# Few minor [checkstyle warnings|https://builds.apache.org/job/PreCommit-HDFS-Build/17673/artifact/patchprocess/diff-checkstyle-hadoop-hdfs-project.txt]
reported, please take care.
# Just a suggstion. Its good practice to give message. Probably can use like below,
{code}
Assert.assertFalse("SPS should not start when a Mover instance is running", active);
{code}

[~umamaheswararao], could you please let me know your views about the necessity of [double
checks ensuring that SPS/Mover is not running together|https://issues.apache.org/jira/browse/HDFS-10885?focusedCommentId=15648191&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15648191],
thanks!

> [SPS]: Mover tool should not be allowed to run when Storage Policy Satisfier is on
> ----------------------------------------------------------------------------------
>
>                 Key: HDFS-10885
>                 URL: https://issues.apache.org/jira/browse/HDFS-10885
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: datanode, namenode
>    Affects Versions: HDFS-10285
>            Reporter: Wei Zhou
>            Assignee: Wei Zhou
>             Fix For: HDFS-10285
>
>         Attachments: HDFS-10800-HDFS-10885-00.patch, HDFS-10800-HDFS-10885-01.patch,
HDFS-10800-HDFS-10885-02.patch, HDFS-10885-HDFS-10285.03.patch, HDFS-10885-HDFS-10285.04.patch,
HDFS-10885-HDFS-10285.05.patch, HDFS-10885-HDFS-10285.06.patch, HDFS-10885-HDFS-10285.07.patch,
HDFS-10885-HDFS-10285.08.patch
>
>
> These two can not work at the same time to avoid conflicts and fight with each other.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org


Mime
View raw message