hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Rakesh R (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-10885) [SPS]: Mover tool should not be allowed to run when Storage Policy Satisfier is on
Date Wed, 23 Nov 2016 13:46:58 GMT

    [ https://issues.apache.org/jira/browse/HDFS-10885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15690140#comment-15690140
] 

Rakesh R commented on HDFS-10885:
---------------------------------

bq. So, the case can not be tested by restarting the NN. What's your opinion?
Yes, we can do NN restart and verify specific cases. I'd prefer to add a test case if possible.
Tests will help us, not to break the behavior mistakenly by anyone in future. Probably you
can refer my previous comment for the same and do a try. [Sample test case showing NN restarts|https://github.com/apache/hadoop/blob/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDFSStripedOutputStreamWithFailure.java#L279]

bq. The reason of using two different values is that I want to disable SPS for unit tests
while enable it by default when actually been deployed. 
How about setting to {{false}} explicitly for those testcases where you want to disable SPS?.
That way we can keep default value {{true}}, consistent in all the places - source code or
doc, right?
{code}
final Configuration conf = new HdfsConfiguration();
conf.setBoolean(DFSConfigKeys.DFS_NAMENODE_SPS_ENABLED_KEY, false);
final MiniDFSCluster cluster = new MiniDFSCluster.Builder(conf)
       .numDataNodes(3)
       .storageTypes(new StorageType[][] {{StorageType.DISK}, {StorageType.DISK},
               {StorageType.DISK}}).build();
{code}

bq. It's great! I file a JIRA to do this task.
Thanks for volunteering. Please go ahead, if any help please ping me.

> [SPS]: Mover tool should not be allowed to run when Storage Policy Satisfier is on
> ----------------------------------------------------------------------------------
>
>                 Key: HDFS-10885
>                 URL: https://issues.apache.org/jira/browse/HDFS-10885
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: datanode, namenode
>    Affects Versions: HDFS-10285
>            Reporter: Wei Zhou
>            Assignee: Wei Zhou
>             Fix For: HDFS-10285
>
>         Attachments: HDFS-10800-HDFS-10885-00.patch, HDFS-10800-HDFS-10885-01.patch,
HDFS-10800-HDFS-10885-02.patch, HDFS-10885-HDFS-10285.03.patch, HDFS-10885-HDFS-10285.04.patch,
HDFS-10885-HDFS-10285.05.patch, HDFS-10885-HDFS-10285.06.patch, HDFS-10885-HDFS-10285.07.patch
>
>
> These two can not work at the same time to avoid conflicts and fight with each other.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org


Mime
View raw message