hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Zhe Zhang (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-10872) Add MutableRate metrics for FSNamesystemLock operations
Date Thu, 10 Nov 2016 19:31:58 GMT

    [ https://issues.apache.org/jira/browse/HDFS-10872?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15654899#comment-15654899

Zhe Zhang commented on HDFS-10872:

Thanks Erik for the patch! LGTM overall. I think the added {{newMutableRatesWithAggregation}}
constructor is reasonable. Some minors:
# Below change doesn't seem necessary
-  private final MetricsRegistry registry = new MetricsRegistry("FSNamesystem");
+  private final MetricsRegistry registry =
+      new MetricsRegistry("FSNamesystem").setContext("dfs");
# We could have the @link have its own line, right now the link is broken:
 * If metrics are enabled by setting {@link org.apache.hadoop.hdfs.DFSConfigKeys
 * #DFS_NAMENODE_LOCK_DETAILED_METRICS_KEY} to be true, metrics will be emitted
# Follow-on: maybe we can consider consolidating the code in readUnlock and writeUnlock

[~andrew.wang] Any further comments? Thanks.

> Add MutableRate metrics for FSNamesystemLock operations
> -------------------------------------------------------
>                 Key: HDFS-10872
>                 URL: https://issues.apache.org/jira/browse/HDFS-10872
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: namenode
>            Reporter: Erik Krogen
>            Assignee: Erik Krogen
>         Attachments: FSLockPerf.java, HDFS-10872.000.patch, HDFS-10872.001.patch, HDFS-10872.002.patch,
HDFS-10872.003.patch, HDFS-10872.004.patch, HDFS-10872.005.patch, HDFS-10872.006.patch
> Add metrics for FSNamesystemLock operations to see, overall, how long each operation
is holding the lock for. Use MutableRate metrics for now. 

This message was sent by Atlassian JIRA

To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org

View raw message