hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-10177) a wrong number of the bytes read are copied into native buffer in hdfsRead()
Date Wed, 30 Nov 2016 23:42:58 GMT

    [ https://issues.apache.org/jira/browse/HDFS-10177?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15710230#comment-15710230
] 

Hadoop QA commented on HDFS-10177:
----------------------------------

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  0m 16s{color} | {color:blue}
Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  0s{color} |
{color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red}  0m  0s{color} | {color:red}
The patch doesn't appear to include any new or modified tests. Please justify why no new tests
are needed for this patch. Also please list what manual steps were performed to verify this
patch. {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  7m 29s{color}
| {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 16s{color} |
{color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green}  0m 14s{color} |
{color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green}  0m 13s{color}
| {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  0m  9s{color}
| {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 14s{color} |
{color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} cc {color} | {color:green}  0m 14s{color} | {color:green}
the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  0m 14s{color} | {color:green}
the patch passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green}  0m 11s{color} |
{color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green}  0m  9s{color}
| {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m  0s{color}
| {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green}  0m 34s{color} | {color:green}
hadoop-hdfs-native-client in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 19s{color}
| {color:green} The patch does not generate ASF License warnings. {color} |
| {color:black}{color} | {color:black} {color} | {color:black} 10m 56s{color} | {color:black}
{color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker |  Image:yetus/hadoop:a9ad5d6 |
| JIRA Issue | HDFS-10177 |
| JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12841147/HDFS-10177.002.patch
|
| Optional Tests |  asflicense  compile  cc  mvnsite  javac  unit  |
| uname | Linux 209bc5719ffe 3.13.0-96-generic #143-Ubuntu SMP Mon Aug 29 20:15:20 UTC 2016
x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /testptch/hadoop/patchprocess/precommit/personality/provided.sh |
| git revision | trunk / 69fb70c |
| Default Java | 1.8.0_111 |
|  Test Results | https://builds.apache.org/job/PreCommit-HDFS-Build/17718/testReport/ |
| modules | C: hadoop-hdfs-project/hadoop-hdfs-native-client U: hadoop-hdfs-project/hadoop-hdfs-native-client
|
| Console output | https://builds.apache.org/job/PreCommit-HDFS-Build/17718/console |
| Powered by | Apache Yetus 0.4.0-SNAPSHOT   http://yetus.apache.org |


This message was automatically generated.



> a wrong number of the bytes read are copied into native buffer in hdfsRead()
> ----------------------------------------------------------------------------
>
>                 Key: HDFS-10177
>                 URL: https://issues.apache.org/jira/browse/HDFS-10177
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: libhdfs
>    Affects Versions: 2.6.0, 2.7.2, 2.6.2, 2.6.3, 2.6.4
>         Environment: RHEL 6.3, 64-bit
> Oralce JDK 1.7.0_55
>            Reporter: Yongtao Yang
>            Assignee: Andres Perez
>              Labels: newbie
>         Attachments: HDFS-10177.002.patch, HDFS-10177.patch
>
>
> in the implementation of {{hdfsRead()}},
> {code:title=hdfsRead.c}
> tSize hdfsRead(hdfsFS fs, hdfsFile f, void* buffer, tSize length)
> {
> ......
> jint noReadBytes = length;
> ......
>     jthr = invokeMethod(env, &jVal, INSTANCE, jInputStream, HADOOP_ISTRM,
>                                "read", "([B)I", jbRarray);
>     if (jthr) {
>         destroyLocalReference(env, jbRarray);
>         errno = printExceptionAndFree(env, jthr, PRINT_EXC_ALL,
>             "hdfsRead: FSDataInputStream#read");
>         return -1;
>     }
>     if (jVal.i < 0) {
>         // EOF
>         destroyLocalReference(env, jbRarray);
>         return 0;
>     } else if (jVal.i == 0) {
>         destroyLocalReference(env, jbRarray);
>         errno = EINTR;
>         return -1;
>     }
>     (*env)->GetByteArrayRegion(env, jbRarray, 0, noReadBytes, buffer);
> {code}
> The problem is, {{noReadBytes}} is initialized to {{length}}, but it should be set {{jVal.i}}
(in the last line) before the bytes are copied to the native {{buffer}}.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org


Mime
View raw message