Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 7C3E6200B8B for ; Tue, 4 Oct 2016 18:36:22 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 7B099160AC7; Tue, 4 Oct 2016 16:36:22 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id A42BF160ACC for ; Tue, 4 Oct 2016 18:36:21 +0200 (CEST) Received: (qmail 83500 invoked by uid 500); 4 Oct 2016 16:36:20 -0000 Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list hdfs-issues@hadoop.apache.org Received: (qmail 83449 invoked by uid 99); 4 Oct 2016 16:36:20 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 04 Oct 2016 16:36:20 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id 888B32C0B05 for ; Tue, 4 Oct 2016 16:36:20 +0000 (UTC) Date: Tue, 4 Oct 2016 16:36:20 +0000 (UTC) From: "Rushabh S Shah (JIRA)" To: hdfs-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HDFS-10878) TestDFSClientRetries#testIdempotentAllocateBlockAndClose throws ConcurrentModificationException MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Tue, 04 Oct 2016 16:36:22 -0000 [ https://issues.apache.org/jira/browse/HDFS-10878?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15545903#comment-15545903 ] Rushabh S Shah commented on HDFS-10878: --------------------------------------- Thanks [~kihwal] for reviews and committing. > TestDFSClientRetries#testIdempotentAllocateBlockAndClose throws ConcurrentModificationException > ----------------------------------------------------------------------------------------------- > > Key: HDFS-10878 > URL: https://issues.apache.org/jira/browse/HDFS-10878 > Project: Hadoop HDFS > Issue Type: Bug > Components: hdfs-client > Affects Versions: 2.7.3 > Reporter: Rushabh S Shah > Assignee: Rushabh S Shah > Fix For: 2.7.4, 3.0.0-alpha2 > > Attachments: HDFS-10878-1.patch, HDFS-10878.patch > > > This failed in our internal build > {noformat} > java.util.ConcurrentModificationException: null > at java.util.ArrayList$Itr.checkForComodification(ArrayList.java:901) > at java.util.ArrayList$Itr.next(ArrayList.java:851) > at org.apache.hadoop.hdfs.server.blockmanagement.BlockInfoContiguousUnderConstruction.appendUCParts(BlockInfoContiguousUnderConstruction.java:396) > at org.apache.hadoop.hdfs.server.blockmanagement.BlockInfoContiguousUnderConstruction.appendStringTo(BlockInfoContiguousUnderConstruction.java:382) > at org.apache.hadoop.hdfs.server.blockmanagement.BlockInfoContiguousUnderConstruction.toString(BlockInfoContiguousUnderConstruction.java:375) > at java.lang.String.valueOf(String.java:2982) > at java.lang.StringBuilder.append(StringBuilder.java:131) > at org.apache.hadoop.hdfs.protocol.ExtendedBlock.toString(ExtendedBlock.java:121) > at com.google.common.base.Joiner.toString(Joiner.java:533) > at com.google.common.base.Joiner.appendTo(Joiner.java:124) > at com.google.common.base.Joiner.appendTo(Joiner.java:181) > at com.google.common.base.Joiner.join(Joiner.java:237) > at com.google.common.base.Joiner.join(Joiner.java:226) > at com.google.common.base.Joiner.join(Joiner.java:245) > at org.apache.hadoop.hdfs.TestDFSClientRetries$3.answer(TestDFSClientRetries.java:485) > at org.apache.hadoop.hdfs.TestDFSClientRetries$3.answer(TestDFSClientRetries.java:477) > at org.mockito.internal.stubbing.StubbedInvocationMatcher.answer(StubbedInvocationMatcher.java:31) > at org.mockito.internal.MockHandler.handle(MockHandler.java:97) > at org.mockito.internal.creation.MethodInterceptorFilter.intercept(MethodInterceptorFilter.java:47) > at org.apache.hadoop.hdfs.server.namenode.NameNodeRpcServer$$EnhancerByMockitoWithCGLIB$$cca97ed1.complete() > at org.apache.hadoop.hdfs.DFSOutputStream.completeFile(DFSOutputStream.java:2303) > at org.apache.hadoop.hdfs.DFSOutputStream.closeImpl(DFSOutputStream.java:2279) > at org.apache.hadoop.hdfs.DFSOutputStream.close(DFSOutputStream.java:2243) > at org.apache.hadoop.hdfs.TestDFSClientRetries.testIdempotentAllocateBlockAndClose(TestDFSClientRetries.java:507) > {noformat} > Its getting NPE in following Log message > {code:title=TestDFSClientRetries.java|borderStyle=solid} > @Test > public void testIdempotentAllocateBlockAndClose() throws Exception { > ... > public Boolean answer(InvocationOnMock invocation) throws Throwable { > // complete() may return false a few times before it returns > // true. We want to wait until it returns true, and then > // make it retry one more time after that. > LOG.info("Called complete(: " + > Joiner.on(",").join(invocation.getArguments()) + ")"); > ... > } > {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org