Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id CDFF1200BBE for ; Thu, 27 Oct 2016 10:05:00 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id CCB58160AF6; Thu, 27 Oct 2016 08:05:00 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 1D3D5160AE4 for ; Thu, 27 Oct 2016 10:04:59 +0200 (CEST) Received: (qmail 92129 invoked by uid 500); 27 Oct 2016 08:04:59 -0000 Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list hdfs-issues@hadoop.apache.org Received: (qmail 91890 invoked by uid 99); 27 Oct 2016 08:04:58 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 27 Oct 2016 08:04:58 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id 9EF742C2A68 for ; Thu, 27 Oct 2016 08:04:58 +0000 (UTC) Date: Thu, 27 Oct 2016 08:04:58 +0000 (UTC) From: "Vinayakumar B (JIRA)" To: hdfs-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HDFS-10769) BlockIdManager.clear doesn't reset the counter for blockGroupIdGenerator MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Thu, 27 Oct 2016 08:05:00 -0000 [ https://issues.apache.org/jira/browse/HDFS-10769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15611107#comment-15611107 ] Vinayakumar B commented on HDFS-10769: -------------------------------------- +1 for the latest patch. Thanks [~rakeshr] for the test. Pending Jenkins > BlockIdManager.clear doesn't reset the counter for blockGroupIdGenerator > ------------------------------------------------------------------------ > > Key: HDFS-10769 > URL: https://issues.apache.org/jira/browse/HDFS-10769 > Project: Hadoop HDFS > Issue Type: Bug > Components: hdfs > Affects Versions: 3.0.0-alpha1, 3.0.0-beta1 > Reporter: Ewan Higgs > Assignee: Yiqun Lin > Priority: Minor > Labels: newbie > Attachments: HDFS-10769-002.patch, HDFS-10769.001.patch > > > BlockIdManager.clear resets the block id generator for contiguous blocks but not for striped blocks: > {code} > void clear() { > legacyGenerationStamp.setCurrentValue(GenerationStamp.LAST_RESERVED_STAMP); > generationStamp.setCurrentValue(GenerationStamp.LAST_RESERVED_STAMP); > getBlockIdGenerator().setCurrentValue(SequentialBlockIdGenerator > .LAST_RESERVED_BLOCK_ID); > legacyGenerationStampLimit = HdfsConstants.GRANDFATHER_GENERATION_STAMP; > } > {code} > This should have: > {code} > getBlockGroupIdGenerator().setCurrentValue(Long.MIN_VALUE); > {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org