hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Wei-Chiu Chuang (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-11018) Incorrect check and message in FsDatasetImpl#invalidate
Date Wed, 19 Oct 2016 22:43:58 GMT

    [ https://issues.apache.org/jira/browse/HDFS-11018?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15590094#comment-15590094
] 

Wei-Chiu Chuang commented on HDFS-11018:
----------------------------------------

LGTM +1 on the 003 patch.

> Incorrect check and message in FsDatasetImpl#invalidate
> -------------------------------------------------------
>
>                 Key: HDFS-11018
>                 URL: https://issues.apache.org/jira/browse/HDFS-11018
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: datanode
>            Reporter: Wei-Chiu Chuang
>            Assignee: Yiqun Lin
>         Attachments: HDFS-11018.001.patch, HDFS-11018.002.patch, HDFS-11018.003.patch
>
>
> The following error check and message is incorrect, because {{info}} is null if (1) the
block id does not exist in ReplicaMap or (2) the generation stamp of block does not match
the replica entry in ReplicaMap.
> {code:title=FsDatasetImpl#invalidate}
>        final ReplicaInfo info = volumeMap.get(bpid, invalidBlks[i]);
>         if (info == null) {
>           // It is okay if the block is not found -- it may be deleted earlier.
>           LOG.info("Failed to delete replica " + invalidBlks[i]
>               + ": ReplicaInfo not found.");
>           continue;
>         }
>         if (info.getGenerationStamp() != invalidBlks[i].getGenerationStamp()) {
>           errors.add("Failed to delete replica " + invalidBlks[i]
>               + ": GenerationStamp not matched, info=" + info);
>           continue;
>         }
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org


Mime
View raw message