hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-11012) Unnecessary INFO logging on DFSClients for InvalidToken
Date Fri, 14 Oct 2016 07:42:20 GMT

    [ https://issues.apache.org/jira/browse/HDFS-11012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15574558#comment-15574558

ASF GitHub Bot commented on HDFS-11012:

GitHub user QwertyManiac opened a pull request:


    HDFS-11012. Unnecessary INFO logging on DFSClients for InvalidToken.

    This is for JIRA: https://issues.apache.org/jira/browse/HDFS-11012

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/QwertyManiac/hadoop HDFS-11012

Alternatively you can review and apply these changes as the patch at:


To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #142
commit a3391db2be233b11705268b36f698eff960bed4a
Author: Harsh J <harsh@cloudera.com>
Date:   2016-10-14T07:41:11Z

    HDFS-11012. Unnecessary INFO logging on DFSClients for InvalidToken.


> Unnecessary INFO logging on DFSClients for InvalidToken
> -------------------------------------------------------
>                 Key: HDFS-11012
>                 URL: https://issues.apache.org/jira/browse/HDFS-11012
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: fs
>    Affects Versions: 2.5.0
>            Reporter: Harsh J
>            Assignee: Harsh J
>            Priority: Minor
> In situations where a DFSClient would receive an InvalidToken exception (as described
at [1]), a single retry is automatically made (as observed at [2]). However, we still print
an INFO message into the DFSClient's logger even though the message is expected in some scenarios.
This should ideally be a DEBUG level message to avoid confusion.
> If the retry or the retried attempt fails, the final clause handles it anyway and prints
out a proper WARN (as seen at [3]) so the INFO is unnecessary.
> [1] - https://github.com/apache/hadoop/blob/release-2.7.0/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSInputStream.java#L1330-L1356
> [2] - https://github.com/apache/hadoop/blob/release-2.7.0/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSInputStream.java#L649-L651
and https://github.com/apache/hadoop/blob/release-2.7.0/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSInputStream.java#L1163-L1170
> [3] - https://github.com/apache/hadoop/blob/release-2.7.0/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSInputStream.java#L652-L658
and https://github.com/apache/hadoop/blob/release-2.7.0/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSInputStream.java#L1171-L1177

This message was sent by Atlassian JIRA

To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org

View raw message