hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Kai Zheng (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-11007) AliyunOSSInputStream#read() should update read bytes stat correctly
Date Fri, 14 Oct 2016 00:41:20 GMT

    [ https://issues.apache.org/jira/browse/HDFS-11007?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15573684#comment-15573684
] 

Kai Zheng commented on HDFS-11007:
----------------------------------

Thanks [~liuml07] for the reporting. The patch LGTM and +1. Will convert it to a HADOOP one.

> AliyunOSSInputStream#read() should update read bytes stat correctly
> -------------------------------------------------------------------
>
>                 Key: HDFS-11007
>                 URL: https://issues.apache.org/jira/browse/HDFS-11007
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: tools
>            Reporter: Mingliang Liu
>            Assignee: Mingliang Liu
>         Attachments: HDFS-11007.000.patch
>
>
> {code}
>   @Override
>   public synchronized int read() throws IOException {
>     ......
>     if (statistics != null && byteRead >= 0) {
>       statistics.incrementBytesRead(1);
>     }
>     return byteRead;
>   }
> {code}
> I believe it should be {{statistics.incrementBytesRead(byteRead);}}?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org


Mime
View raw message