hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Xiaoyu Yao (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-10984) Expose nntop output as metrics
Date Mon, 10 Oct 2016 19:13:20 GMT

    [ https://issues.apache.org/jira/browse/HDFS-10984?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15563190#comment-15563190
] 

Xiaoyu Yao commented on HDFS-10984:
-----------------------------------

Thanks [~swagle] for reporting the issue and posting the patch. The latest patch v2 with the
JMXGet issue fixed looks good to me overall. 
Here are a few minor issues:

1. In TopMetrics#getMetrics(), should we check if top metrics is enabled or not like we do
in FSNamesystem#getTopUserOpCounts. Or have a unit test verify that the metrics source works
as expected when top metrics is not enabled.

2. I notice that the patch added a metric record per window. So there would be multiple record
per getMetrics() call for each window. Can we elaborate this in the description of the comments?


3. Checkstyle issue from Jenkins.

> Expose nntop output as metrics   
> ---------------------------------
>
>                 Key: HDFS-10984
>                 URL: https://issues.apache.org/jira/browse/HDFS-10984
>             Project: Hadoop HDFS
>          Issue Type: Task
>          Components: namenode
>    Affects Versions: 2.7.0
>            Reporter: Siddharth Wagle
>            Assignee: Siddharth Wagle
>             Fix For: 2.7.3
>
>         Attachments: HDFS-10984.patch, HDFS-10984.v1.patch, HDFS-10984.v2.patch
>
>
> The nntop output is already exposed via JMX with HDFS-6982.
> However external metrics systems do not get this data. It would be valuable to track
this as a timeseries as well.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org


Mime
View raw message