hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Daryn Sharp (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-10930) Refactor: Wrap Datanode IO related operations
Date Wed, 12 Oct 2016 15:46:20 GMT

    [ https://issues.apache.org/jira/browse/HDFS-10930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15569080#comment-15569080
] 

Daryn Sharp commented on HDFS-10930:
------------------------------------

Took a cursory look, do we really need to move non-redundant and non-general use methods into
a new class just to add a log line for duration?  I'm not a huge fan of kitchen sink classes
of static methods because it's counter to polymorphism and it usually makes tests, particularly
mocks, wicked hard to write.

> Refactor: Wrap Datanode IO related operations
> ---------------------------------------------
>
>                 Key: HDFS-10930
>                 URL: https://issues.apache.org/jira/browse/HDFS-10930
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: datanode
>            Reporter: Xiaoyu Yao
>            Assignee: Xiaoyu Yao
>         Attachments: HDFS-10930.01.patch, HDFS-10930.02.patch
>
>
> Datanode IO (Disk/Network) related operations and instrumentations are currently spilled
in many classes such as DataNode.java, BlockReceiver.java, BlockSender.java, FsDatasetImpl.java,
FsVolumeImpl.java, DirectoryScanner.java, BlockScanner.java, FsDatasetAsyncDiskService.java,
LocalReplica.java, LocalReplicaPipeline.java, Storage.java, etc. 
> This ticket is opened to consolidate IO related operations for easy instrumentation,
metrics collection, logging and trouble shooting. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org


Mime
View raw message