hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Weiwei Yang (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-10922) Adding additional unit tests for Trash (II)
Date Fri, 14 Oct 2016 13:48:20 GMT

    [ https://issues.apache.org/jira/browse/HDFS-10922?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15575379#comment-15575379
] 

Weiwei Yang commented on HDFS-10922:
------------------------------------

Hello [~xyao]

v11 patch is ready for review now, it contains following changes

# Moved an existing permission check test from TestDFSPermission to TestHDFSTrash, renamed
to {{testMoveUnprivilegedDirToTrash}}
# Added a test case {{testHDFSTrashPermission}} by reusing the test case in TestTrash
# Added a test case {{testMoveEmptyDirToTrash}} by reusing the test case in TestTrash
# Added a test case {{testDeleteTrash}} to verify an user cannot delete other user's trash
dir

Note that I did not add a test for #4 in the original proposal [here|https://issues.apache.org/jira/browse/HDFS-10922?focusedCommentId=15530965&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15530965],
because it is already addressed in  {{TestTrash#testTrashRestarts}} via HADOOP-13686.

Please let me know if you have any other comments.

Thanks!

> Adding additional unit tests for Trash (II)
> -------------------------------------------
>
>                 Key: HDFS-10922
>                 URL: https://issues.apache.org/jira/browse/HDFS-10922
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: test
>            Reporter: Xiaoyu Yao
>            Assignee: Weiwei Yang
>         Attachments: HDFS-10922.02.patch, HDFS-10922.03.patch, HDFS-10922.04.patch, HDFS-10922.05.patch,
HDFS-10922.06.patch, HDFS-10922.07.patch, HDFS-10922.08.patch, HDFS-10922.09.patch, HDFS-10922.10.patch,
HDFS-10922.11.patch
>
>
> This ticket is opened to track adding unit tests for Trash.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org


Mime
View raw message