hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Xiaoyu Yao (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-10906) Add unit tests for Trash with HDFS encryption zones
Date Fri, 14 Oct 2016 17:32:21 GMT

    [ https://issues.apache.org/jira/browse/HDFS-10906?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15575948#comment-15575948
] 

Xiaoyu Yao commented on HDFS-10906:
-----------------------------------

Thanks for the update [~hanishakoneru]. Here are some additional minor issues. 

1. Fix the checkstyle issue
2. DFSTestUtil#verifyDelete(), since we are dealing with HDFS path, the following
can be simplified from
{code}
Path trashPath = Path.mergePaths(shell.getCurrentTrashDir(path), path);
{code}

to 
{code}
Path trashPath = new Path(shell.getCurrentTrashDir(path), path);
{code}

TestTrashWithSecureEncryptionZones.java
3. NIT: Can we put all static imports in a single block before the non-static imports?

4. The following two counters should be AtomicInteger
{code}
private static int zoneCounter = 1;
private static int fileCounter = 1;
{code}


> Add unit tests for Trash with HDFS encryption zones
> ---------------------------------------------------
>
>                 Key: HDFS-10906
>                 URL: https://issues.apache.org/jira/browse/HDFS-10906
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: encryption
>    Affects Versions: 2.8.0
>            Reporter: Xiaoyu Yao
>            Assignee: Hanisha Koneru
>         Attachments: HDFS-10906.000.patch, HDFS-10906.001.patch, HDFS-10906.002.patch
>
>
> The goal is to improve unit test coverage for HDFS trash with encryption zone especially
under Kerberos environment. The current unit test TestEncryptionZones#testEncryptionZonewithTrash()
has limited coverage on non-Kerberos case.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org


Mime
View raw message