hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Zhe Zhang (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-10872) Add MutableRate metrics for FSNamesystemLock operations
Date Tue, 18 Oct 2016 23:35:59 GMT

    [ https://issues.apache.org/jira/browse/HDFS-10872?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15587033#comment-15587033

Zhe Zhang commented on HDFS-10872:

Thanks Erik! The v3 patch LGTM. +1 pending fixing the long line checkstyle issue.
* {@link org.apache.hadoop.hdfs.DFSConfigKeys#DFS_NAMENODE_LOCK_METRIC_AGG_INTERVAL_MS_KEY}

I think we should leave the try-and-backoff as a potential optimization.

I will hold off committing the patch until EOD Thursday to collect more feedbacks. [~kihwal]
Do you think the patch addresses your [use cases | https://issues.apache.org/jira/browse/HDFS-10475?focusedCommentId=15490522&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15490522]?
[~andrew.wang] Do you think the aggregation method addresses your concern on performance (see
benchmark above)? [~liuml07] Any comments on the form of output?

> Add MutableRate metrics for FSNamesystemLock operations
> -------------------------------------------------------
>                 Key: HDFS-10872
>                 URL: https://issues.apache.org/jira/browse/HDFS-10872
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: namenode
>            Reporter: Erik Krogen
>            Assignee: Erik Krogen
>         Attachments: FSLockPerf.java, HDFS-10872.000.patch, HDFS-10872.001.patch, HDFS-10872.002.patch,
> Add metrics for FSNamesystemLock operations to see, overall, how long each operation
is holding the lock for. Use MutableRate metrics for now. 

This message was sent by Atlassian JIRA

To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org

View raw message