hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mehran Hassani (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-9618) Fix mismatch between log level and guard in BlockManager#computeRecoveryWorkForBlocks
Date Fri, 07 Oct 2016 21:52:20 GMT

    [ https://issues.apache.org/jira/browse/HDFS-9618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15556346#comment-15556346
] 

Mehran Hassani commented on HDFS-9618:
--------------------------------------

Correct me if I am wrong but I think self4j checks for all the log levels before making the
string so doing IsLevelEnabled() is unnecessary when you use it.  

> Fix mismatch between log level and guard in BlockManager#computeRecoveryWorkForBlocks
> -------------------------------------------------------------------------------------
>
>                 Key: HDFS-9618
>                 URL: https://issues.apache.org/jira/browse/HDFS-9618
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: namenode
>    Affects Versions: 2.8.0
>            Reporter: Masatake Iwasaki
>            Assignee: Masatake Iwasaki
>            Priority: Minor
>             Fix For: 2.9.0, 3.0.0-alpha1
>
>         Attachments: HDFS-9618.001.patch, HDFS-9618.002.patch
>
>
> Debug log message is constructed when {{Logger#isInfoEnabled}}.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org


Mime
View raw message