hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Andrew Wang (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-8630) WebHDFS : Support get/set/unset StoragePolicy
Date Thu, 13 Oct 2016 00:13:20 GMT

    [ https://issues.apache.org/jira/browse/HDFS-8630?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15570330#comment-15570330
] 

Andrew Wang commented on HDFS-8630:
-----------------------------------

Hi Surendra, thanks for working on this. Overall looks great! The patch needs a rebase, but
some review comments:

* Need @Test annotation on testStoragePolicyParam to run it
* Want to combine the two minicluster tests in TestWebHDFS? testGetAllStoragePolicy is mostly
boilerplate, so we can save some code.
* For Get All Storage Policies, I think we should wrap it in a "BlockStoragePolicies" dictionary,
the way we have "FileStatuses" and then "FileStatus". This is important to differentiate from
when we have an array of BlockStoragePolicies vs. a single item like in Get Storage Policy.
* Would be good to add some tests for error cases, like when storage policies are disabled,
or the policy can't be changed.

Do you want to also add HttpFS support, perhaps in a follow-on patch? This is pretty important
for secure clusters.

> WebHDFS : Support get/set/unset StoragePolicy 
> ----------------------------------------------
>
>                 Key: HDFS-8630
>                 URL: https://issues.apache.org/jira/browse/HDFS-8630
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>            Reporter: nijel
>            Assignee: Surendra Singh Lilhore
>         Attachments: HDFS-8630.001.patch, HDFS-8630.002.patch, HDFS-8630.003.patch, HDFS-8630.004.patch,
HDFS-8630.005.patch, HDFS-8630.006.patch, HDFS-8630.007.patch, HDFS-8630.patch
>
>
> User can set and get the storage policy from filesystem object. Same operation can be
allowed trough REST API.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org


Mime
View raw message