hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Manoj Govindassamy (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (HDFS-5684) o.a.h.fs.viewfs.ViewFileSystem.MountPoint has no public methods.
Date Tue, 25 Oct 2016 21:50:58 GMT

    [ https://issues.apache.org/jira/browse/HDFS-5684?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15606579#comment-15606579
] 

Manoj Govindassamy edited comment on HDFS-5684 at 10/25/16 9:50 PM:
--------------------------------------------------------------------

* For now its used by tests only. We already expose org.apache.hadoop.fs.viewfs.ConfigUtil
to client apps to programmatically add Mount points to the conf. May be these clients would
be interested to look at all the existing mount points in the ViewFileSystem and it make sense
to have a separate ViewFsAdmin. Even without ViewFsAdmin, client apps can now cast the FileSystem
to ViewFileSystem and access MountPoints if needed. Without src/target methods being public,
client apps will not be able to see them. But, I think having a separate Admin class is much
cleaner than they having to cast and get internal details.

* Updated the test to make use of SL4J instead of commons logging. 

Attached v02 patch. Please take a look.


was (Author: manojg):
* For now its used by tests only. We already expose org.apache.hadoop.fs.viewfs.ConfigUtil
to client apps to programmatically add Mount points to the conf. May be these clients would
be interested to look at all the existing mount points in the ViewFileSystem and it make sense
to have a separate ViewFsAdmin. Even without ViewFsAdmin, client apps can now cast the FileSystem
to ViewFileSystem and access MountPoints if needed. Without src/target methods being public,
client apps will not be able to see them. But, I think having a separate Admin class is much
cleaner than they having to cast and get internal details.

* Updated the test to make use of SL4J instead of commons logging. 

> o.a.h.fs.viewfs.ViewFileSystem.MountPoint has no public methods.
> ----------------------------------------------------------------
>
>                 Key: HDFS-5684
>                 URL: https://issues.apache.org/jira/browse/HDFS-5684
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: hdfs-client
>    Affects Versions: 3.0.0-alpha2
>            Reporter: Keith Turner
>            Assignee: Manoj Govindassamy
>         Attachments: HDFS-5684.01.patch, HDFS-5684.02.patch
>
>
> o.a.h.fs.viewfs.ViewFileSystem provides the following method
> {noformat}
>   public MountPoint[] getMountPoints()
> {noformat}
> However MountPoint has no public methods making getMountPoints() useless.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org


Mime
View raw message