Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 794BA200B9B for ; Wed, 28 Sep 2016 01:22:23 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 77D19160AE5; Tue, 27 Sep 2016 23:22:23 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id BEFBF160AD2 for ; Wed, 28 Sep 2016 01:22:22 +0200 (CEST) Received: (qmail 51332 invoked by uid 500); 27 Sep 2016 23:22:21 -0000 Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list hdfs-issues@hadoop.apache.org Received: (qmail 51307 invoked by uid 99); 27 Sep 2016 23:22:21 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 27 Sep 2016 23:22:21 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id BB5232C0B04 for ; Tue, 27 Sep 2016 23:22:21 +0000 (UTC) Date: Tue, 27 Sep 2016 23:22:21 +0000 (UTC) From: "Allen Wittenauer (JIRA)" To: hdfs-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HDFS-10892) Add unit tests for HDFS command 'dfs -tail' and 'dfs -stat' MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Tue, 27 Sep 2016 23:22:23 -0000 [ https://issues.apache.org/jira/browse/HDFS-10892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15527755#comment-15527755 ] Allen Wittenauer commented on HDFS-10892: ----------------------------------------- The Dockerfile that ships with Hadoop does not force a UTF-8 locale. So it will inherit whatever locale was running at the UNIX level. Apache Yetus will only force the locale to be a UTF-8 variant if shellcheck is involved. I'd recommend that if the test needs UTF-8, then the test should set the locale it needs and then restore. If setting the UTF-8 locale fails, then the test should be skipped. There's no guarantee that a user running the test is even UTF-8 capable. > Add unit tests for HDFS command 'dfs -tail' and 'dfs -stat' > ----------------------------------------------------------- > > Key: HDFS-10892 > URL: https://issues.apache.org/jira/browse/HDFS-10892 > Project: Hadoop HDFS > Issue Type: Sub-task > Components: fs, shell, test > Reporter: Mingliang Liu > Assignee: Mingliang Liu > Attachments: HDFS-10892.000.patch, HDFS-10892.001.patch, HDFS-10892.002.patch, HDFS-10892.003.patch, HDFS-10892.004.patch > > > I did not find unit test in {{trunk}} code for following cases: > - HDFS command {{dfs -tail}} > - HDFS command {{dfs -stat}} > I think it still merits to have one though the commands have served us for years. -- This message was sent by Atlassian JIRA (v6.3.4#6332) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org