Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 80A14200B9B for ; Tue, 27 Sep 2016 20:30:22 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 7F73F160AB9; Tue, 27 Sep 2016 18:30:22 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id EE16F160AD2 for ; Tue, 27 Sep 2016 20:30:21 +0200 (CEST) Received: (qmail 75081 invoked by uid 500); 27 Sep 2016 18:30:21 -0000 Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list hdfs-issues@hadoop.apache.org Received: (qmail 74905 invoked by uid 99); 27 Sep 2016 18:30:21 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 27 Sep 2016 18:30:21 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id DB4342C2A65 for ; Tue, 27 Sep 2016 18:30:20 +0000 (UTC) Date: Tue, 27 Sep 2016 18:30:20 +0000 (UTC) From: "Daryn Sharp (JIRA)" To: hdfs-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Updated] (HDFS-10779) Rename does not need to re-solve destination MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Tue, 27 Sep 2016 18:30:22 -0000 [ https://issues.apache.org/jira/browse/HDFS-10779?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daryn Sharp updated HDFS-10779: ------------------------------- Attachment: HDFS-10779.patch Stopped calling {{FSDirectory#isDir}} and completely removed the method. Extensively use IIP instead of passing around string paths. Modified rename txns and return result to remove need to re-resolve path again just to audit log. > Rename does not need to re-solve destination > -------------------------------------------- > > Key: HDFS-10779 > URL: https://issues.apache.org/jira/browse/HDFS-10779 > Project: Hadoop HDFS > Issue Type: Sub-task > Components: hdfs > Reporter: Daryn Sharp > Assignee: Daryn Sharp > Attachments: HDFS-10779.patch > > > Rename uses {{FSDirectory.isDir(String)}} to determine if the destination is a directory. This dissect the path, creates an IIP, checks if the last inode is a directory. The rename operations already have the IIP and can check it directly. -- This message was sent by Atlassian JIRA (v6.3.4#6332) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org