Return-Path: <hdfs-issues-return-168909-archive-asf-public=cust-asf.ponee.io@hadoop.apache.org>
X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io
Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io
Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183])
	by cust-asf2.ponee.io (Postfix) with ESMTP id 7CCCE200B8F
	for <archive-asf-public-internal@cust-asf2.ponee.io>; Fri, 16 Sep 2016 06:48:22 +0200 (CEST)
Received: by cust-asf.ponee.io (Postfix)
	id 7B379160AD7; Fri, 16 Sep 2016 04:48:22 +0000 (UTC)
Delivered-To: archive-asf-public@cust-asf.ponee.io
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by cust-asf.ponee.io (Postfix) with SMTP id BA498160AC6
	for <archive-asf-public@cust-asf.ponee.io>; Fri, 16 Sep 2016 06:48:21 +0200 (CEST)
Received: (qmail 34880 invoked by uid 500); 16 Sep 2016 04:48:20 -0000
Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:hdfs-issues-help@hadoop.apache.org>
List-Unsubscribe: <mailto:hdfs-issues-unsubscribe@hadoop.apache.org>
List-Post: <mailto:hdfs-issues@hadoop.apache.org>
List-Id: <hdfs-issues.hadoop.apache.org>
Delivered-To: mailing list hdfs-issues@hadoop.apache.org
Received: (qmail 34863 invoked by uid 99); 16 Sep 2016 04:48:20 -0000
Received: from arcas.apache.org (HELO arcas) (140.211.11.28)
    by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 16 Sep 2016 04:48:20 +0000
Received: from arcas.apache.org (localhost [127.0.0.1])
	by arcas (Postfix) with ESMTP id 90ABF2C0D5B
	for <hdfs-issues@hadoop.apache.org>; Fri, 16 Sep 2016 04:48:20 +0000 (UTC)
Date: Fri, 16 Sep 2016 04:48:20 +0000 (UTC)
From: "John Zhuge (JIRA)" <jira@apache.org>
To: hdfs-issues@hadoop.apache.org
Message-ID: <JIRA.12991037.1469002393000.586855.1474001300589@Atlassian.JIRA>
In-Reply-To: <JIRA.12991037.1469002393000@Atlassian.JIRA>
References: <JIRA.12991037.1469002393000@Atlassian.JIRA> <JIRA.12991037.1469002393131@arcas>
Subject: [jira] [Updated] (HDFS-10657) testAclCLI.xml setfacl test should
 expect mask r-x
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394
archived-at: Fri, 16 Sep 2016 04:48:22 -0000


     [ https://issues.apache.org/jira/browse/HDFS-10657?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

John Zhuge updated HDFS-10657:
------------------------------
    Issue Type: Test  (was: Bug)

> testAclCLI.xml setfacl test should expect mask r-x
> --------------------------------------------------
>
>                 Key: HDFS-10657
>                 URL: https://issues.apache.org/jira/browse/HDFS-10657
>             Project: Hadoop HDFS
>          Issue Type: Test
>    Affects Versions: 2.6.0
>            Reporter: John Zhuge
>            Assignee: John Zhuge
>            Priority: Minor
>             Fix For: 2.8.0
>
>         Attachments: HDFS-10657.001.patch
>
>
> The following test case should expect {{mask::r-x}} ACL entry instead of {{mask::rwx}}:
> {code:xml}
>       <description>setfacl : check inherit default ACL to dir</description>
>       <test-commands>
>         <command>-fs NAMENODE -mkdir /dir1</command>
>         <command>-fs NAMENODE -setfacl -m default:user:charlie:r-x,default:group:admin:rwx /dir1</command>
>         <command>-fs NAMENODE -mkdir /dir1/dir2</command>
>         <command>-fs NAMENODE -getfacl /dir1/dir2</command>
> ...
>         <comparator>
>           <type>SubstringComparator</type>
>           <expected-output>mask::rwx</expected-output>
>         </comparator>
> {code}
> But why does it pass? Because the comparator type is {{SubstringComparator}} and it matches the wrong line {{default:mask::rwx}} in the output of {{getfacl}}:
> {noformat}
> # file: /dir1/dir2
> # owner: jzhuge
> # group: supergroup
> user::rwx
> user:charlie:r-x
> group::r-x
> group:admin:rwx	#effective:r-x
> mask::r-x
> other::r-x
> default:user::rwx
> default:user:charlie:r-x
> default:group::r-x
> default:group:admin:rwx
> default:mask::rwx
> default:other::r-x
> {noformat}
> The comparator should match the entire line instead of just substring. Other comparators in {{testAclCLI.xml}} have the same problem.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org