Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 99B91200B95 for ; Tue, 13 Sep 2016 03:27:23 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 98317160AC8; Tue, 13 Sep 2016 01:27:23 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id DD78D160AB8 for ; Tue, 13 Sep 2016 03:27:22 +0200 (CEST) Received: (qmail 982 invoked by uid 500); 13 Sep 2016 01:27:21 -0000 Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list hdfs-issues@hadoop.apache.org Received: (qmail 574 invoked by uid 99); 13 Sep 2016 01:27:21 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 13 Sep 2016 01:27:21 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id E12CF2C1B79 for ; Tue, 13 Sep 2016 01:27:20 +0000 (UTC) Date: Tue, 13 Sep 2016 01:27:20 +0000 (UTC) From: "Manoj Govindassamy (JIRA)" To: hdfs-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HDFS-10599) DiskBalancer: Execute CLI via Shell MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Tue, 13 Sep 2016 01:27:23 -0000 [ https://issues.apache.org/jira/browse/HDFS-10599?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15485897#comment-15485897 ] Manoj Govindassamy commented on HDFS-10599: ------------------------------------------- Thanks for the review [~xiaobingo]. 1. Yes, Report command doesn't need 'fs' option. But 'fs' being a generic option, all Commands should work well with 'fs' option. Since DiskBalancer methods were run directly from the TestBalancerCommand unit tests, generic options weren't added during the run and the Commands used to fail with unexpected option errors. So, the intention of this jira is to make the test run DiskBalancer Commands just like the way it runs in real command line shell via DiskBalancerCLI main and there by have access to all generic options. So, added a unit test to prove DiskBalancer Commands can be run with GenericOptions like "fs". 2. Thats right. Removed the out parameter from DiskBalancerCLI#dispatch. Thanks for catching this. Attaching v002 patch with more test comments and with redundant out argument removed. > DiskBalancer: Execute CLI via Shell > ------------------------------------ > > Key: HDFS-10599 > URL: https://issues.apache.org/jira/browse/HDFS-10599 > Project: Hadoop HDFS > Issue Type: Sub-task > Components: balancer & mover > Affects Versions: 3.0.0-alpha1 > Reporter: Anu Engineer > Assignee: Manoj Govindassamy > Attachments: HDFS-10599.001.patch > > > DiskBalancer CLI invokes CLI functions directly instead of shell. This is not representative of how end users use it. To provide good unit test coverage, we need to have tests where DiskBalancer CLI is invoked via shell. -- This message was sent by Atlassian JIRA (v6.3.4#6332) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org